Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Fail tests if screenshot fails #51

Closed
1 task done
thespad opened this issue Aug 27, 2024 · 0 comments · Fixed by #52
Closed
1 task done

[FEAT] Fail tests if screenshot fails #51

thespad opened this issue Aug 27, 2024 · 0 comments · Fixed by #52
Assignees
@GilbN
Labels
enhancement New feature or request

Comments

@thespad
Copy link
Member

thespad commented Aug 27, 2024

Is this a new feature request?

  • I have searched the existing issues

Wanted change

Fail test if screenshot fails for amd64

Reason for change

Currently failed screenshots don't fail the CI test. Really if we're expecting successful screenshots we should fail if we don't get them.

Proposed code change

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GilbN GilbN

Labels
enhancement New feature or request
Projects
Issue & PR Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

If amd64 tag fails the screenshot test, mark CI.report_status with "FAIL". linuxserver/docker-ci
2 participants
@thespad @GilbN