Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Display the name of the builder that ran the test #48

Closed
1 task done
aptalca opened this issue Aug 20, 2024 · 0 comments
Closed
1 task done

[FEAT] Display the name of the builder that ran the test #48

aptalca opened this issue Aug 20, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@aptalca
Copy link
Member

aptalca commented Aug 20, 2024

Is this a new feature request?

  • I have searched the existing issues

Wanted change

It would be nice if the ci test result lists the name of the builder that ran the test.

Reason for change

  • There are some significant differences between hetzner and contabo ones in terms of timings
  • If we get a bunch of builds fail, we may be able to spot an issue with an individual builder much more easily by simply clicking through ci reports in the discord channel

Proposed code change

Accept an env var where the builder name can be passed as a value, and display it in the ci test result. Jenkins automatically sets the var NODE_NAME and we use that to display it in the build logs: https://github.com/linuxserver/docker-jenkins-builder/blob/master/roles/generate-jenkins/templates/Jenkinsfile.j2#L43
We only need to display the amd64 builder because the entire test runs on there.
An issue with an arm builder would likely result in a build failure rather than a test failure.

@aptalca aptalca added the enhancement New feature or request label Aug 20, 2024
@GilbN GilbN self-assigned this Aug 24, 2024
@GilbN GilbN closed this as completed Aug 26, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants