Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/qt5platform-plugins #61

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#269

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#269
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • cursorThemePropertyChanged 函数中使用了 QMetaObject::invokeMethod,但没有提供具体的槽函数,可能会导致运行时错误。
  • cursorThemePropertyChanged 函数中的 Q_UNUSED 宏没有实际用途,因为 connectionnamepropertyhandle 参数在函数体内没有被使用。
  • cursorThemePropertyChanged 函数中的 for 循环遍历了所有窗口,可能会影响性能,特别是当窗口数量较多时。
  • cursorThemePropertyChanged 函数中的 overrideChangeCursor 调用没有错误处理,如果失败可能会导致未定义行为。

是否建议立即修改:

  • 应该提供具体的槽函数来处理 QMetaObject::invokeMethod 的调用。
  • 移除 Q_UNUSED 宏,因为它们没有实际用途。
  • 考虑优化 for 循环,避免不必要的窗口遍历,或者使用更高效的数据结构来管理窗口。
  • overrideChangeCursor 调用中添加错误处理,确保即使操作失败也不会导致程序崩溃。

@mhduiy mhduiy merged commit f55f219 into master Jan 8, 2025
29 of 31 checks passed
@mhduiy mhduiy deleted the sync-pr-269-nosync branch January 8, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants