Multiple logging based .cpp and .h are missing original copyrights in dtkcore.

[openarun]

SUMMARY | 问题概要

Multiples files under include/log/* and src/log/* are missing the original copyrights in dtkcore.

DTK and OS VERSIONS | DTK&系统版本信息

dtkcore: 5.6.30

Minimal Reproducible Case Code | 最小复现案例代码

Related commits:
[1] linuxdeepin/dtkcore@1b07dac
[2] linuxdeepin/dtkcore@24a29a0

OBSERVED RESULT | 观察到的结果

No response

EXPECTED RESULT | 期望的结果

No response

ADDITIONAL INFORMATION | 额外补充

No response

[BLumia]

We're not quite understand. Does it mean the original author still needs to be credited (but not declared as copyright holder) in both .cpp and .h files? Thanks!

To clarify, the cleanroom implementation is intended to avoid licensing issues. The header files are not able to change too much due to the avoidance of API/ABI breaks.

[openarun]

For an example, Logger.cpp :
On comparing [1] and [2] , I see that the source codes are a modified version but not a complete rewritten.
So, I think should preserve the original copyright and license which is LGPL-2.1 in both cpp and header files.

[1] https://github.com/linuxdeepin/dtkcore/blob/master/src/log/Logger.cpp
[2] https://github.com/dept2/CuteLogger/blob/master/src/Logger.cpp

[BLumia]

Possible solutions:

1. the mentioned option, try to ask the CuteLogger dev to relicense the code to LGPL2.1+
2. • add back the credit and license to those files that are not cleanroom reimplemented, then at least the project as a whole can be released under GPLv3 without issue.
   • add compile time option to block the CuteLogger usage so it can be released under LGPL3+ when such option enabled, and GPL3+ if disabled.
   • add a new logger from scratch as an alternative, but use another set of APIs to avoid conflict.
3. remove the vendored CuteLogger usage, package and use CuteLogger as a separated library

cc @zccrs @asterwyx