Skip to content

Commit 4f6d4e8

Browse files
committed
refactor: Update CMake build flags and Debian packaging
Refactor CMake files to: - Remove redundant C++ standard version flags. - Correctly apply security hardening linker flags by using CMAKE_EXE_LINKER_FLAGS and string(APPEND). - Adjust the installation path for coredump reporter systemd user services. Update Debian packaging rules: - Migrate from debhelper to debhelper-compat (= 11) in debian/control. - Remove the debian/compat file.
1 parent 3f15354 commit 4f6d4e8

File tree

8 files changed

+8
-38
lines changed

8 files changed

+8
-38
lines changed

application/CMakeLists.txt

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,9 @@ set(CMAKE_AUTORCC ON)
2424
#set(CMAKE_CXX_FLAGS "-g -Wall")
2525
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall")#${EXE_NAME}
2626
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wl,--as-needed -fPIE")
27-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
2827
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -pie")
2928
#安全测试加固编译参数
30-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -z relro -z now -z noexecstack -pie")
31-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -z relro -z now -z noexecstack -pie")
29+
string(APPEND CMAKE_EXE_LINKER_FLAGS " -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -pie")
3230
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fstack-protector-all")
3331
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fstack-protector-all")
3432

@@ -38,11 +36,6 @@ if(CMAKE_COVERAGE_ARG STREQUAL "CMAKE_COVERAGE_ARG_ON")
3836
endif()
3937

4038
set(APP_RES_DIR "assets")
41-
#安全测试加固编译参数
42-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -z relro -z now -z noexecstack -pie")
43-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -z relro -z now -z noexecstack -pie")
44-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fstack-protector-all")
45-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fstack-protector-all")
4639

4740
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIE")
4841
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fPIE")
@@ -358,7 +351,7 @@ install(FILES configs/logconfig/deepin-log-viewer.json DESTINATION ${CMAKE_INSTA
358351
install(FILES configs/debugconfig/org.deepin.log.viewer.json DESTINATION ${CMAKE_INSTALL_PREFIX}/share/deepin-debug-config/deepin-debug-config.d/)
359352

360353
# Install coredump report service&timer
361-
install(FILES ./configs/coredump-reporter.timer ./configs/coredump-reporter.service DESTINATION lib/systemd/user/)
354+
install(FILES ./configs/coredump-reporter.timer ./configs/coredump-reporter.service DESTINATION ${CMAKE_INSTALL_PREFIX}/lib/systemd/user/)
362355

363356
#安装DConfig配置
364357
set(APPID org.deepin.log.viewer)

debian/compat

Lines changed: 0 additions & 1 deletion
This file was deleted.

debian/control

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Section: utils
33
Priority: optional
44
Maintainer: Deepin Packages Builder <[email protected]>
55
Build-Depends:
6-
debhelper (>= 11),
6+
debhelper-compat (= 11),
77
cmake,
88
pkg-config,
99
qt6-5compat-dev | libgsettings-qt-dev,

liblogviewerplugin/CMakeLists.txt

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,15 @@ set(CMAKE_AUTOMOC ON)
1616
set(CMAKE_AUTORCC ON)
1717
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall")#${EXE_NAME}
1818
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wl,--as-needed -fPIE")
19-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
2019
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -pie")
2120
#安全测试加固编译参数
22-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -z relro -z now -z noexecstack -pie")
23-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -z relro -z now -z noexecstack -pie")
21+
string(APPEND CMAKE_EXE_LINKER_FLAGS " -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -pie")
2422
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fstack-protector-all")
2523
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fstack-protector-all")
2624
if(CMAKE_COVERAGE_ARG STREQUAL "CMAKE_COVERAGE_ARG_ON")
2725
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g -Wall -fprofile-arcs -ftest-coverage")
2826
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -Wall -fprofile-arcs -ftest-coverage")
2927
endif()
30-
#安全测试加固编译参数
31-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -z relro -z now -z noexecstack -pie")
32-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -z relro -z now -z noexecstack -pie")
33-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fstack-protector-all")
34-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fstack-protector-all")
3528
if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "sw_64")
3629
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mieee")
3730
endif ()

logViewerAuth/CMakeLists.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ set(CMAKE_INCLUDE_CURRENT_DIR ON)
1515
set(CMAKE_AUTOMOC ON)
1616
set(CMAKE_AUTORCC ON)
1717
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall")
18-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
1918
#set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g -fsanitize=undefined,address -O2")
2019
#set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -fsanitize=undefined,address -O2")
2120

@@ -25,8 +24,7 @@ if(CMAKE_COVERAGE_ARG STREQUAL "CMAKE_COVERAGE_ARG_ON")
2524
endif()
2625

2726
#安全测试加固编译参数
28-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -z relro -z now -z noexecstack -pie")
29-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -z relro -z now -z noexecstack -pie")
27+
string(APPEND CMAKE_EXE_LINKER_FLAGS " -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -pie")
3028
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fstack-protector-all")
3129
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fstack-protector-all")
3230

logViewerService/CMakeLists.txt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,14 @@ if(CMAKE_COVERAGE_ARG STREQUAL "CMAKE_COVERAGE_ARG_ON")
1717
endif()
1818

1919
#安全测试加固编译参数
20-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -z relro -z now -z noexecstack -pie")
21-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -z relro -z now -z noexecstack -pie")
20+
string(APPEND CMAKE_EXE_LINKER_FLAGS " -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -pie")
2221
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fstack-protector-all")
2322
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fstack-protector-all")
2423

2524
set(APP_RES_DIR "assets")
2625
set(APP_SERVICE "${APP_RES_DIR}/data/com.deepin.logviewer.service")
2726
set(APP_SYSTEMD_SERVICE "${APP_RES_DIR}/data/deepin-log-viewer-daemon.service")
2827
set(APP_CONFIG "${APP_RES_DIR}/data/com.deepin.logviewer.conf")
29-
#安全测试加固编译参数
30-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -z relro -z now -z noexecstack -pie")
31-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -z relro -z now -z noexecstack -pie")
32-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fstack-protector-all")
33-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fstack-protector-all")
3428

3529
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIE")
3630
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fPIE")

logViewerTruncate/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@ if(CMAKE_COVERAGE_ARG STREQUAL "CMAKE_COVERAGE_ARG_ON")
2222
endif()
2323

2424
#安全测试加固编译参数
25-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -z relro -z now -z noexecstack -pie")
26-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -z relro -z now -z noexecstack -pie")
25+
string(APPEND CMAKE_EXE_LINKER_FLAGS " -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -pie")
2726
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fstack-protector-all")
2827
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fstack-protector-all")
2928

tests/CMakeLists.txt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -fprofile-arcs -ftest-coverage")
2323
#添加-fno-inline编译选项,禁止内联,能获取到函数地址,可以对内联函数进行打桩
2424
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-inline")
2525
#安全测试加固编译参数
26-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -z relro -z now -z noexecstack -pie")
27-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -z relro -z now -z noexecstack -pie")
26+
string(APPEND CMAKE_EXE_LINKER_FLAGS " -Wl,-z,relro -Wl,-z,now -Wl,-z,noexecstack -pie")
2827
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fstack-protector-all")
2928
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fstack-protector-all")
3029
if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "sw_64")
@@ -36,11 +35,6 @@ if(CMAKE_SAFETYTEST STREQUAL "")
3635
set(CMAKE_SAFETYTEST "CMAKE_SAFETYTEST_ARG_OFF")
3736
endif()
3837
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -D${CMAKE_SAFETYTEST}")
39-
#安全测试加固编译参数
40-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -z relro -z now -z noexecstack -pie")
41-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -z relro -z now -z noexecstack -pie")
42-
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fstack-protector-all")
43-
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fstack-protector-all")
4438
if(CMAKE_SAFETYTEST STREQUAL "CMAKE_SAFETYTEST_ARG_ON")
4539
#安全测试选项
4640
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g -fsanitize=undefined,address -O2")

0 commit comments

Comments
 (0)