Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update deepin 25 #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Zeno-sole
Copy link
Collaborator

No description provided.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Zeno-sole

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Oct 28, 2024

TAG Bot

TAG: 2025.01.06
EXISTED: no
DISTRIBUTION: unstable

@Zeno-sole
Copy link
Collaborator Author

/integrate

Copy link

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#2147
PrNumber: 2147
PrBranch: auto-integration-11548713538

@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. Makefile 修改

    • VERSION := 23 修改为 VERSION := 25,确认是否有相应的代码逻辑需要更新以匹配新的版本号。
  2. debian/changelog 修改

    • deepin-desktop-base (2025.01.06) 中,update os-version 应该是 update os-version to 25,以明确指出版本更新内容。
    • deepin-desktop-base (2024.10.28) 中,updatge v25 Release 应该是 update to v25 Release,以修正拼写错误。
  3. files/os-version-xxx 文件修改

    • 所有文件中的 MajorVersionMinorVersion 都从 23 更新为 25,确认这是否符合预期。
    • OsBuild 的版本号格式从 310xx.xxxx 更新为 210xx.xxxx.100,确认这是否符合版本控制规范。
    • EditionName 中增加了 (Preview),确认这是否符合产品发布策略。
  4. 文件命名和路径

    • files/os-version-amdfiles/os-version-armfiles/os-version-loongfiles/os-version-riscv 文件名中的 amdarmloongriscv 是否正确反映了文件内容,或者是否应该统一命名。
  5. 版本控制

    • 确认版本号更新是否与代码库中的其他版本号一致,例如 Makefile 中的 VERSIONfiles/os-version-xxx 文件中的 MajorVersionMinorVersion
  6. 国际化

    • 确认 EditionName 的修改是否在所有支持的语言中都进行了更新,包括 en_USzh_CN
  7. 代码风格

    • 确认代码风格是否一致,例如缩进和空格的使用是否遵循项目规范。
  8. 注释和文档

    • 确认是否有必要在 changelogfiles/os-version-xxx 文件中添加更多的注释,以便于理解版本更新的原因和影响。

总体来说,这些修改看起来是为了更新版本号和版本信息,但需要确保这些更改与项目的整体策略和版本控制流程一致。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants