Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add deepin-service-plugin-network #294

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

caixr23
Copy link
Contributor

@caixr23 caixr23 commented Dec 27, 2024

Add deepin-service-plugin-network

pms: BUG-294423
pms: BUG-294395

Add deepin-service-plugin-network

pms: BUG-294423
pms: BUG-294395
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. CMakeLists.txt:

    • network-service-pluginCMakeLists.txt文件中,将Qt5KF5替换为${QT_NS}${KF_NS}可能会导致未定义的变量错误,除非这些变量在之前的代码中被正确定义。建议检查这些变量的定义。
  2. debian/control:

    • debian/control文件中添加了deepin-service-plugin-network包的依赖项deepin-service-plugin-network,这是一个自引用,可能是一个错误。应该检查是否需要添加其他依赖项。
  3. network-service-plugin/CMakeLists.txt:

    • network-service-plugin/CMakeLists.txt文件中,将Qt5KF5替换为${QT_NS}${KF_NS}可能会导致未定义的变量错误,除非这些变量在之前的代码中被正确定义。建议检查这些变量的定义。
  4. network-service-plugin/accountnetwork/session/accountnetwork/account.cpp:

    • account.cpp文件中,将com.deepin.dde.LockService替换为org.deepin.dde.LockService1,这可能会导致与旧版本的不兼容。建议确认新服务的可用性和兼容性。
  5. network-service-plugin/accountnetwork/session/accountnetwork/activeaccoutnetwork.cpp:

    • activeaccoutnetwork.cpp文件中,将com.deepin.daemon.Network替换为org.deepin.dde.Network1,这可能会导致与旧版本的不兼容。建议确认新服务的可用性和兼容性。
  6. network-service-plugin/accountnetwork/session/accountnetwork/networkactivator.cpp:

    • networkactivator.cpp文件中,将com.deepin.system.Network替换为org.deepin.dde.Network1,这可能会导致与旧版本的不兼容。建议确认新服务的可用性和兼容性。
  7. network-service-plugin/accountnetwork/system/accountnetwork/accountmanager.cpp:

    • accountmanager.cpp文件中,将com.deepin.daemon.Accounts替换为org.deepin.dde.Accounts1,这可能会导致与旧版本的不兼容。建议确认新服务的可用性和兼容性。
  8. network-service-plugin/ipconflicthandler.cpp:

    • ipconflicthandler.cpp文件中,将WpaSae替换为SAE,这可能会导致与旧版本的不兼容。建议确认新枚举值的可用性和兼容性。
  9. network-service-plugin/session/browserassist.cpp:

    • browserassist.cpp文件中,将com.deepin.dde.Dock替换为org.deepin.dde.Dock1,这可能会导致与旧版本的不兼容。建议确认新服务的可用性和兼容性。
  10. network-service-plugin/session/sessioncontainer.cpp:

    • sessioncontainer.cpp文件中,将com.deepin.daemon.Network替换为org.deepin.dde.Network1,这可能会导致与旧版本的不兼容。建议确认新服务的可用性和兼容性。
  11. network-service-plugin/system/connectivitychecker.cpp:

    • connectivitychecker.cpp文件中,添加了QProcess头文件,但未看到对应的代码使用。建议确认是否需要添加此头文件。
  12. network-service-plugin/system/networkinitialization.cpp:

    • networkinitialization.cpp文件中,进行了大量的重构和代码修改,包括使用QDBusMessageQDBusPendingReply替代了之前的QDBusInterface。建议确认这些修改是否正确,并且是否与旧版本兼容。

总体来说,这些修改涉及到多个服务接口的变更,需要确保这些变更不会影响现有功能,并且与新的服务接口兼容。同时,建议进行充分的测试来验证这些修改的正确性和稳定性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: caixr23, fly602

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caixr23 caixr23 merged commit f81d8d8 into linuxdeepin:master Dec 27, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants