fix: incorrect override format for json when export to OEM

[18202781743]

translate value to json string.
escape csv field.

Summary by Sourcery

Fixes an issue where JSON values were not correctly formatted when exporting to OEM, and also escapes CSV fields to ensure proper handling of commas, quotes, and newlines.

Bug Fixes:

• Fixes incorrect JSON formatting when exporting to OEM.
• Escapes CSV fields to handle commas, quotes, and newlines correctly.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses an issue with incorrect formatting when exporting data to OEM in JSON format. It introduces changes to properly escape CSV fields, convert QVariants to JSON strings, and ensure correct encoding. The changes involve modifications to oemdialog.cpp and helper.hpp.

Sequence diagram for saving data to CSV file

sequenceDiagram
    participant OEMDialog
    participant QFile
    participant QTextStream

    OEMDialog->>QFile: open(fileName, WriteOnly | Text)
    activate QFile
    QFile-->>OEMDialog: isOpen()
    deactivate QFile

    alt file is open
        OEMDialog->>QTextStream: create(file)
        activate QTextStream
        OEMDialog->>QTextStream: setCodec("UTF-8")
        OEMDialog->>QTextStream: write header row
        loop for each item in m_overrides
            OEMDialog->>OEMDialog: escapeCsvField(item data)
            OEMDialog->>QTextStream: write escaped data to file
        end
        OEMDialog->>QTextStream: flush()
        deactivate QTextStream
    else file is not open
        OEMDialog->>OEMDialog: handle error
    end

Loading

File-Level Changes

Change	Details	Files
Added a function to escape CSV fields to ensure proper formatting and prevent issues with commas, quotes, and newlines within the data.	Implemented escapeCsvField function to encapsulate the logic for escaping CSV fields. Replaced double quotes with two double quotes inside the field. Added surrounding quotes if the field contains commas, quotes, or newlines.	dconfig-center/dde-dconfig-editor/oemdialog.cpp
Modified the saveCSVFile function to use the new escapeCsvField function and ensure UTF-8 encoding.	Added out.setCodec("UTF-8") to ensure proper encoding of the CSV file. Used escapeCsvField to escape each field before writing to the CSV file. Used qvariantToStringCompact to convert the QVariant to a compact JSON string.	dconfig-center/dde-dconfig-editor/oemdialog.cpp
Updated the displayChangedResult function to use qvariantToString for displaying the value in the tree view.	Replaced item->data(ValueRole).toString() with qvariantToString(item->data(ValueRole)) when creating the DStandardItem for the value.	dconfig-center/dde-dconfig-editor/oemdialog.cpp
Modified the getItemWidget function to use qvariantToString and stringToQVariant for handling text in the DLineEdit widget.	Used qvariantToString to set the text of the DLineEdit widget. Used stringToQVariant to set the data of the item when the text in the DLineEdit widget changes.	dconfig-center/dde-dconfig-editor/oemdialog.cpp
Added a new function qvariantToStringCompact to convert QVariant to a compact JSON string.	Implemented qvariantToStringCompact function to convert QVariant to a compact JSON string using QJsonDocument::Compact.	dconfig-center/common/helper.hpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[deepin-ci-robot]

deepin pr auto review

关键摘要:

• qvariantToStringCompact 函数中使用了 const auto &doc，但未对 doc.isNull() 进行检查，可能导致未定义行为。
• escapeCsvField 函数中，escaped.replace("\"", "\"\""); 可能会导致无限循环，因为 " 在替换过程中会不断被替换。
• saveCSVFile 函数中，out.setCodec("UTF-8"); 应该在文件打开后立即设置，以确保文件编码正确。
• saveCSVFile 函数中，out << escapeCsvField(qvariantToStringCompact(item->data(ValueRole))) << ","; 应该使用 qvariantToString 以保持一致性。
• displayChangedResult 函数中，item->data(ValueRole).toString() 应该使用 qvariantToString 以保持一致性。
• getItemWidget 函数中，widget->setText(v.toString()); 应该使用 qvariantToString 以保持一致性。

是否建议立即修改:
是

[sourcery-ai]

Hey @18202781743 - I've reviewed your changes - here's some feedback:

Overall Comments:

• Consider adding a unit test for the escapeCsvField function to ensure it handles various edge cases correctly.
• It might be helpful to add comments explaining the purpose of qvariantToStringCompact and stringToQVariant.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment