Skip to content

Commit c2ea24d

Browse files
cristibirsanasimion797
authored andcommitted
ASoC: atmel: mchp-asrc: fix printk format specifier warnings
This patch fixes the following warnings discovered on 64 bit platforms: sound/soc/atmel/mchp-asrc.c:1275:25: error: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Werror=format=] sound/soc/atmel/mchp-asrc-dma.c:275:17: error: format '%x' expects argument of type 'unsigned int', but argument 6 has type 'phys_addr_t' {aka 'long long unsigned int'} [-Werror=format=] sound/soc/atmel/mchp-asrc-dma.c:677:25: error: format '%u' expects argument of type 'unsigned int', but argument 6 has type 'size_t' {aka 'long unsigned int'} [-Werror=format=] Fix specifiers using guidance in [1]. Link: https://www.kernel.org/doc/Documentation/printk-formats.txt [1] Fixes: 0b902c5 ("ASoC: atmel: Add ASRC driver") Signed-off-by: Cristian Birsan <[email protected]> Signed-off-by: Conor Dooley <[email protected]> Acked-by: Nicolas Ferre <[email protected]> (cherry picked from linux-6.1-trunk/at91/sound) Signed-off-by: Andrei Simion <[email protected]>
1 parent e5f2061 commit c2ea24d

File tree

2 files changed

+30
-16
lines changed

2 files changed

+30
-16
lines changed

sound/soc/atmel/mchp-asrc-dma.c

+26-12
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,8 @@ static void mchp_asrc_start_handle(unsigned long data)
258258
dma_async_issue_pending(dma_be_priv->desc->chan);
259259
}
260260

261-
static int mchp_asrc_dmaengine_pcm_prepare_slave_config(struct snd_pcm_substream *substream,
261+
static int mchp_asrc_dmaengine_pcm_prepare_slave_config(struct device *dev,
262+
struct snd_pcm_substream *substream,
262263
struct snd_pcm_hw_params *params,
263264
struct snd_dmaengine_dai_dma_data *dma_data,
264265
struct dma_slave_config *slave_config)
@@ -271,6 +272,15 @@ static int mchp_asrc_dmaengine_pcm_prepare_slave_config(struct snd_pcm_substream
271272

272273
snd_dmaengine_pcm_set_config_from_dai_data(substream, dma_data, slave_config);
273274

275+
dev_dbg(dev,
276+
"%s() FE AIF dir %s, src addr %pap, dst addr: %pap, src_addr_width %d, dst_addr_width %d, src maxburst %u, dst maxburst %u\n",
277+
__func__,
278+
slave_config->direction == DMA_MEM_TO_DEV ? "DMA_MEM_TO_DEV" :
279+
"DMA_DEV_TO_MEM",
280+
&slave_config->src_addr, &slave_config->dst_addr,
281+
slave_config->src_addr_width, slave_config->dst_addr_width,
282+
slave_config->src_maxburst, slave_config->dst_maxburst);
283+
274284
return 0;
275285
}
276286

@@ -346,11 +356,11 @@ mchp_asrc_be_dmaengine_slave_config(struct mchp_asrc_dmaengine_dai_dma *dma,
346356
config_be.device_fc = false;
347357

348358
dev_dbg(dev,
349-
"%s() AIF %s dir %s, src addr %#x, dst addr: %#x, src_addr_width %d, dst_addr_width %d, src maxburst %u, dst maxburst %u\n",
359+
"%s() AIF %s dir %s, src addr %pap, dst addr: %pap, src_addr_width %d, dst_addr_width %d, src maxburst %u, dst maxburst %u\n",
350360
__func__, dai->name,
351361
config_be.direction == DMA_MEM_TO_DEV ? "DMA_MEM_TO_DEV" :
352362
"DMA_DEV_TO_MEM",
353-
config_be.src_addr, config_be.dst_addr,
363+
&config_be.src_addr, &config_be.dst_addr,
354364
config_be.src_addr_width, config_be.dst_addr_width,
355365
config_be.src_maxburst, config_be.dst_maxburst);
356366

@@ -477,19 +487,19 @@ static int mchp_asrc_dma_hw_params(struct snd_soc_component *component,
477487
goto __cleanup_free_fe;
478488
}
479489

480-
ret = mchp_asrc_dmaengine_pcm_prepare_slave_config(substream, params, dma_data_fe,
481-
&config_fe);
490+
ret = mchp_asrc_dmaengine_pcm_prepare_slave_config(dev, substream, params,
491+
dma_data_fe, &config_fe);
482492
if (ret) {
483493
dev_err(dev, "failed to prepare DMA config for FE %s\n", cpu_dai->name);
484494
goto __cleanup_dma_fe;
485495
}
486496

487497
dev_dbg(dev,
488-
"%s() config %s: dir %s, src addr %#x, dst addr %#x, src_addr_width %d, dst_addr_width %d, src maxburst %u, dst maxburst %u\n",
498+
"%s() config %s: dir %s, src addr %pap, dst addr %pap, src_addr_width %d, dst_addr_width %d, src maxburst %u, dst maxburst %u\n",
489499
__func__, cpu_dai->name,
490500
config_fe.direction == DMA_MEM_TO_DEV ? "MEM_TO_DEV" :
491501
"DEV_TO_MEM",
492-
config_fe.src_addr, config_fe.dst_addr,
502+
&config_fe.src_addr, &config_fe.dst_addr,
493503
config_fe.src_addr_width, config_fe.dst_addr_width,
494504
config_fe.src_maxburst, config_fe.dst_maxburst);
495505

@@ -667,7 +677,7 @@ static int mchp_asrc_dma_prepare(struct snd_soc_component *component,
667677
rtm_be = subs_be->runtime;
668678

669679
dev_dbg(dev,
670-
"%s() BE buffer_size(periods) %ld, buffer_size(bytes) %u period_size(frames) %ld period_size(bytes) %u\n",
680+
"%s() BE buffer_size(periods) %ld, buffer_size(bytes) %zu period_size(frames) %ld period_size(bytes) %zu\n",
671681
__func__,
672682
rtm_be->buffer_size, snd_pcm_lib_buffer_bytes(subs_be),
673683
rtm_be->period_size, snd_pcm_lib_period_bytes(subs_be));
@@ -730,7 +740,7 @@ static int mchp_asrc_dma_prepare(struct snd_soc_component *component,
730740
rtm_be = subs_be->runtime;
731741

732742
dev_dbg(dev,
733-
"%s() BE buffer_size(periods) %ld, buffer_size(bytes) %u period_size(frames) %ld period_size(bytes) %u\n",
743+
"%s() BE buffer_size(periods) %ld, buffer_size(bytes) %zu period_size(frames) %ld period_size(bytes) %zu\n",
734744
__func__,
735745
rtm_be->buffer_size, snd_pcm_lib_buffer_bytes(subs_be),
736746
rtm_be->period_size, snd_pcm_lib_period_bytes(subs_be));
@@ -761,12 +771,16 @@ static int mchp_asrc_dma_prepare(struct snd_soc_component *component,
761771
dev_err(dev, "failed to prepare client DMA for FE %s\n", cpu_dai->name);
762772
return -ENOMEM;
763773
}
764-
dma_fe_priv->desc = desc;
765774

766-
dev_dbg(dev, "%s() FE buffer_size %ld, period_size %ld\n", __func__,
767-
subs->runtime->buffer_size, subs->runtime->period_size);
775+
dma_fe_priv->desc = desc;
768776
dma_fe_priv->desc->callback = mchp_asrc_pcm_dma_complete;
769777
dma_fe_priv->desc->callback_param = subs;
778+
779+
dev_dbg(dev,
780+
"%s() FE buffer_size(periods) %ld, buffer_size(bytes) %zu period_size(frames) %ld period_size(bytes) %zu\n",
781+
__func__,
782+
subs->runtime->buffer_size, snd_pcm_lib_buffer_bytes(subs),
783+
subs->runtime->period_size, snd_pcm_lib_period_bytes(subs));
770784
} else {
771785
dev_dbg(dev, "%s() FE DMA not found\n", __func__);
772786
}

sound/soc/atmel/mchp-asrc.c

+4-4
Original file line numberDiff line numberDiff line change
@@ -1275,9 +1275,9 @@ static int mchp_asrc_hw_params(struct snd_pcm_substream *substream,
12751275
list_add_tail(&dma_be->list, &dma->dma_in_list);
12761276

12771277
dev_dbg(priv->dev,
1278-
"%s() IN AIF %s: DMA addr %#x DMA chan %s DMA maxburst %d\n",
1278+
"%s() IN AIF %s: DMA addr %pad DMA chan %s DMA maxburst %d\n",
12791279
__func__, trig_be ? trig_be->phandle->np->full_name : dai->name,
1280-
dma_data_be->addr, dma_data_be->chan_name, dma_data_be->maxburst);
1280+
&dma_data_be->addr, dma_data_be->chan_name, dma_data_be->maxburst);
12811281
}
12821282

12831283
INIT_LIST_HEAD(&dma->dma_out_list);
@@ -1315,9 +1315,9 @@ static int mchp_asrc_hw_params(struct snd_pcm_substream *substream,
13151315
list_add_tail(&dma_be->list, &dma->dma_out_list);
13161316

13171317
dev_dbg(priv->dev,
1318-
"%s() OUT AIF %s: DMA addr %#x DMA chan %s DMA maxburst %d\n",
1318+
"%s() OUT AIF %s: DMA addr %pad DMA chan %s DMA maxburst %d\n",
13191319
__func__, trig_be ? trig_be->phandle->np->full_name : dai->name,
1320-
dma_data_be->addr, dma_data_be->chan_name, dma_data_be->maxburst);
1320+
&dma_data_be->addr, dma_data_be->chan_name, dma_data_be->maxburst);
13211321
}
13221322

13231323
/* get the number of free DSPs */

0 commit comments

Comments
 (0)