Skip to content

Commit 78ae618

Browse files
Add label to nodepool (#588)
* add label to nodepool * remove redundant prints --------- Co-authored-by: rpotla <[email protected]>
1 parent f2055c6 commit 78ae618

File tree

4 files changed

+12
-7
lines changed

4 files changed

+12
-7
lines changed

linode_api4/objects/lke.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ class LKENodePool(DerivedBase):
187187
properties = {
188188
"id": Property(identifier=True),
189189
"cluster_id": Property(identifier=True),
190+
"label": Property(mutable=True),
190191
"type": Property(slug_relationship=Type),
191192
"disks": Property(),
192193
"disk_encryption": Property(),
@@ -419,6 +420,7 @@ def node_pool_create(
419420
Union[str, KubeVersion, TieredKubeVersion]
420421
] = None,
421422
update_strategy: Optional[str] = None,
423+
label: str = None,
422424
**kwargs,
423425
):
424426
"""
@@ -444,23 +446,19 @@ def node_pool_create(
444446
for possible values.
445447
446448
:returns: The new Node Pool
449+
:param label: The name of the node pool.
450+
:type label: str
447451
:rtype: LKENodePool
448452
"""
449453
params = {
450454
"type": node_type,
455+
"label": label,
451456
"count": node_count,
452457
"labels": labels,
453458
"taints": taints,
454459
"k8s_version": k8s_version,
455460
"update_strategy": update_strategy,
456461
}
457-
458-
if labels is not None:
459-
params["labels"] = labels
460-
461-
if taints is not None:
462-
params["taints"] = taints
463-
464462
params.update(kwargs)
465463

466464
result = self._client.post(

test/fixtures/lke_clusters_18881_pools_456.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
"foo": "bar",
3535
"bar": "foo"
3636
},
37+
"label": "example-node-pool",
3738
"type": "g6-standard-4",
3839
"disk_encryption": "enabled"
3940
}

test/fixtures/lke_clusters_18882_pools_789.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"id": 789,
33
"type": "g6-standard-2",
4+
"label": "enterprise-node-pool",
45
"count": 3,
56
"nodes": [],
67
"disks": [],

test/unit/objects/lke_test.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ def test_get_pool(self):
5151
assert pool.id == 456
5252
assert pool.cluster_id == 18881
5353
assert pool.type.id == "g6-standard-4"
54+
assert pool.label == "example-node-pool"
5455
assert pool.disk_encryption == InstanceDiskEncryptionType.enabled
5556

5657
assert pool.disks is not None
@@ -162,6 +163,7 @@ def test_load_node_pool(self):
162163
self.assertEqual(pool.id, 456)
163164
self.assertEqual(pool.cluster_id, 18881)
164165
self.assertEqual(pool.type.id, "g6-standard-4")
166+
self.assertEqual(pool.label, "example-node-pool")
165167
self.assertIsNotNone(pool.disks)
166168
self.assertIsNotNone(pool.nodes)
167169
self.assertIsNotNone(pool.autoscaler)
@@ -251,6 +253,7 @@ def test_lke_node_pool_update(self):
251253

252254
pool.tags = ["foobar"]
253255
pool.count = 5
256+
pool.label = "testing-label"
254257
pool.autoscaler = {
255258
"enabled": True,
256259
"min": 2,
@@ -274,6 +277,7 @@ def test_lke_node_pool_update(self):
274277
"min": 2,
275278
"max": 10,
276279
},
280+
"label": "testing-label",
277281
"labels": {
278282
"updated-key": "updated-value",
279283
},
@@ -546,6 +550,7 @@ def test_cluster_enterprise(self):
546550
pool = LKENodePool(self.client, 789, 18882)
547551
assert pool.k8s_version == "1.31.1+lke1"
548552
assert pool.update_strategy == "rolling_update"
553+
assert pool.label == "enterprise-node-pool"
549554

550555
def test_lke_tiered_version(self):
551556
version = TieredKubeVersion(self.client, "1.32", "standard")

0 commit comments

Comments
 (0)