Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs on connection outdated. I would like to take care and refactor it #121

Open
lucafabbian opened this issue Dec 20, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@lucafabbian
Copy link

Hi.

I've seen that the docs on "how to start a session" are outdated.

For example, I used to run:

const {webSocketDebuggerUrl} = await fetch('http://localhost:9222/json/version').then( t => t.json())
const browser = await launch({ wsEndpoint: webSocketDebuggerUrl, headless: false,});
console.log(browser.wsEndpoint());

Which is not possible anymore, despite being part of the docs.
In general, I think it's weird that there are multiple functions to open a session, and that there is not one to connect to a manual browser from the remote debuggin url.

I would like to propose a complete refactor of this method and to document it, if you agree. Possibly taking inspiration from puppetter and golang-rod.

@lino-levan
Copy link
Owner

Ah right, forgot to update the docs after this pr. I would love to see what you come up with.

@lino-levan lino-levan added the documentation Improvements or additions to documentation label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants