address comments

Author: Zihan Li

dao-api/src/main/java/com/linkedin/metadata/dao/utils/RecordUtils.java

@@ -81,7 +81,7 @@ public static String toJsonString(@Nonnull RecordTemplate recordTemplate) {
 
   /**
    * Serializes a {@link RecordTemplate} to JSON string.
-   *Also take test mode as input to control the default value fill in strategy
+   * Also take test mode as input to control the default value fill in strategy
    * @param recordTemplate the record template to serialize
    * @return the JSON string serialized using {@link JacksonDataTemplateCodec}.
    */

dao-api/src/test/java/com/linkedin/metadata/dao/utils/RecordUtilsTest.java

@@ -23,6 +23,7 @@
 import com.linkedin.testing.PizzaInfo;
 import com.linkedin.testing.StringUnion;
 import com.linkedin.testing.StringUnionArray;
+import com.linkedin.testing.MapValueRecord;
 import com.linkedin.testing.singleaspectentity.EntityValue;
 import com.linkedin.testing.urn.FooUrn;
 import java.io.IOException;
@@ -56,7 +57,7 @@ public void testToJsonString() throws IOException {
 
   @Test
   public void testToJsonStringWithDefault() throws IOException {
-    AspectWithDefaultValue defaultValueAspect = new AspectWithDefaultValue();
+    AspectWithDefaultValue defaultValueAspect = new AspectWithDefaultValue().setNestedValueWithDefault(new MapValueRecord());
     String expected =
         loadJsonFromResource("defaultValueAspect.json").replaceAll("\\s+", "").replaceAll("\\n", "").replaceAll("\\r", "");
 

dao-api/src/test/resources/defaultValueAspect.json

@@ -1,3 +1,6 @@
 {
+  "nestedValueWithDefault":{
+    "mapValueWithDefaultmap":{}
+  },
   "valueWithDefault": ""
 }

testing/test-models/src/main/pegasus/com/linkedin/testing/AspectWithDefaultValue.pdl

@@ -6,4 +6,5 @@ record AspectWithDefaultValue {
    * For unit tests
    */
   valueWithDefault: string = ""
+  nestedValueWithDefault: record MapValueRecord {mapValueWithDefaultmap: map[string, string] = { }}
 }