Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set Host on HTTP notifiers #613

Open
reiabreu opened this issue Feb 3, 2020 · 1 comment
Open

Correctly set Host on HTTP notifiers #613

reiabreu opened this issue Feb 3, 2020 · 1 comment

Comments

@reiabreu
Copy link

reiabreu commented Feb 3, 2020

Hi,

According to golang/go#29865, the Host header is ignored is should be set instead using req.Host

Burrow currently supports setting HTTP headers on for the notifiers. It needs a small change for the particular case of the header Host
@reiabreu
Copy link
Author

reiabreu commented Feb 3, 2020

PR: #614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reiabreu