This repository was archived by the owner on Aug 23, 2025. It is now read-only.
Yuniru's CodeReview for You #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file is used for locking strict version of packages. This file should be commited if you are updating your packages, so remove the entry from .gitignore to commit it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
これはなあに？
app/util/app.tsを中心にレビュー＆リファクタリングをしたのでご提案となります。重要な注意
今回大変申し訳無いのですが、配信の都合(設定ファイル上のDiscordAPIキーが配信に映り込んでしまうことを避けたかった)で 「一度も実行をせずに」 このリファクタリングを実行したため、プログラム内容が破壊されている可能性があります。そのためマージはあまり推奨できず、各コミットはあくまで方針の参考としてご利用(するか、マージ前に試験して)ください 🙇♀️ (型が保護してくれる形になったため問題ない可能性もあります)