Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use functions instead of trait methods as the API for src/spline.rs #11

Open
DJMcNab opened this issue Aug 19, 2024 · 0 comments
Open

Comments

@DJMcNab
Copy link
Member

DJMcNab commented Aug 19, 2024

I don't really think that this module has much advantage for understandability in this form. I'd rather see two functions, which can internally use a shared trait.

Originally posted by @DJMcNab in #2 (comment)

That module currently has a trait which is implemented for two types, including a (slice, slice, t) tuple, and a method which iterates through that type. I'd much rather see this be a function instead, so that the parameter names have meaning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant