Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from_u32 on Rgba8 and PremulRgba8 #73

Closed
DJMcNab opened this issue Nov 26, 2024 · 0 comments · Fixed by #135
Closed

from_u32 on Rgba8 and PremulRgba8 #73

DJMcNab opened this issue Nov 26, 2024 · 0 comments · Fixed by #135

Comments

@DJMcNab
Copy link
Member

DJMcNab commented Nov 26, 2024 •
edited
Loading

We have to_u32 on Rgba8 and PremulRgba8, added in #66 (comment). I can foresee use cases (e.g. reading from an image file) where you have the packed representation and would like to operate on the values. Is this an in-scope feature for this crate.

Fwiw, this is already exposed through the bytemuck implementations if you have the relevant feature enabled.
tomcur added a commit to tomcur/color that referenced this issue Jan 18, 2025
@tomcur
Implement (Premul)Rgba8::from_u32 and from_u8_array
b566a3f 
Closes linebender#73.

The conversions from the packed u32 are easy to get wrong when
implemented manually.

(On the other hand, these methods are also easy to use wrong.)
@tomcur tomcur mentioned this issue Jan 18, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 18, 2025
@tomcur
Implement (Premul)Rgba8::from_u32 and from_u8_array (#135)
2f4652e 
Closes #73.

The conversions from the packed u32 are easy to get wrong when
implemented manually.

(On the other hand, these methods are also easy to use wrong.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement (Premul)Rgba8::from_u32 and from_u8_array tomcur/color
1 participant
@DJMcNab