Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

varint encoding for trace and span ids is slow #49

Open
ethercrow opened this issue May 28, 2020 · 0 comments
Open

varint encoding for trace and span ids is slow #49

ethercrow opened this issue May 28, 2020 · 0 comments
Labels

Comments

@ethercrow
Copy link

ethercrow commented May 28, 2020

I've been staring at profiling data and noticed that putVarInt function is rather prominent there, specifically called when serializing trace and span ids. Since those are randomly generated the probability of them fitting into only a few bytes is vanishingly low, preventing any benefits of using variable length encoding.

What do you think about updating collector.proto to define those as fixed64? Quoting Protobuf Developer Guide:

fixed64 | Always eight bytes. More efficient than uint64 if values are often greater than 2^56.

Or maybe Lightstep already can accept trace data in some other protobuf format that is more efficient?

@andrewhsu andrewhsu added the bug label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants