You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been staring at profiling data and noticed that putVarInt function is rather prominent there, specifically called when serializing trace and span ids. Since those are randomly generated the probability of them fitting into only a few bytes is vanishingly low, preventing any benefits of using variable length encoding.
What do you think about updating collector.proto to define those as fixed64? Quoting Protobuf Developer Guide:
fixed64 | Always eight bytes. More efficient than uint64 if values are often greater than 2^56.
Or maybe Lightstep already can accept trace data in some other protobuf format that is more efficient?
The text was updated successfully, but these errors were encountered:
I've been staring at profiling data and noticed that
putVarInt
function is rather prominent there, specifically called when serializing trace and span ids. Since those are randomly generated the probability of them fitting into only a few bytes is vanishingly low, preventing any benefits of using variable length encoding.What do you think about updating
collector.proto
to define those asfixed64
? Quoting Protobuf Developer Guide:Or maybe Lightstep already can accept trace data in some other protobuf format that is more efficient?
The text was updated successfully, but these errors were encountered: