Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make proto doesn't work #47

Open
obecny opened this issue Mar 6, 2020 · 3 comments
Open

make proto doesn't work #47

obecny opened this issue Mar 6, 2020 · 3 comments
Assignees
Labels

Comments

@obecny
Copy link

obecny commented Mar 6, 2020

make proto doesn't work - it gives error

compiling collector.proto [gogo]
/input/github.com/lightstep/lightstep-tracer-common/tmpgen/collector.proto: No such file or directory
make: *** [golang-gogo-collector] Error 1

@andrewhsu
Copy link

@JulianGriggs when you get the chance, can you update a doc or make target or something to address this for future?

@andrewhsu
Copy link

@JulianGriggs sorry, i'll take ownership on tracking what needs to change in this repo to address this issue since this repo is on my regular radar.

@andrewhsu andrewhsu self-assigned this Mar 10, 2020
@obecny
Copy link
Author

obecny commented Mar 10, 2020

I tried to clone this into different path and experimented with makefile and the paths but can't make it work unless this line
https://github.com/lightstep/lightstep-tracer-common/blob/master/metrics.proto#L10
is changed into

import "collector.proto";

the corresponding Makefile script

proto:
	protoc -I"$(PWD)/../googleapis/:$(PWD)/../lightstep-tracer-common/" \
		--js_out=import_style=commonjs,binary:packages/dd-trace/src/generated_proto \
		metrics.proto collector.proto \
		google/api/annotations.proto google/api/http.proto

@andrewhsu andrewhsu added the bug label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants