Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused response fields #43

Open
jmacd opened this issue Jan 14, 2020 · 0 comments
Open

Remove unused response fields #43

jmacd opened this issue Jan 14, 2020 · 0 comments
Labels

Comments

@jmacd
Copy link
Contributor

jmacd commented Jan 14, 2020

The ReportResponse type has three unused fields:

    repeated string errors = 4;
    repeated string warnings = 5;
    repeated string infos = 6;

These should be removed along with any associated client-side functionality. The satellite has (for > 12 months) stopped sending any sort of information via these fields and only uses HTTP or gRPC status codes to indicate various conditions.

@andrewhsu andrewhsu added the bug label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants