From fbf70c9befbcf49adfc6ea22ca98cf67c044f6d9 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Tue, 25 Nov 2025 17:42:24 +0100 Subject: [PATCH 1/2] ci: update build-release --- .github/workflows/build-release.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml index 4553d8b..dbd3390 100644 --- a/.github/workflows/build-release.yml +++ b/.github/workflows/build-release.yml @@ -35,7 +35,6 @@ jobs: sudo apt-get update sudo apt-get install -yq libglib2.0-dev - - run: zig build get-v8 - run: zig build -Doptimize=ReleaseSafe build-v8 - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a @@ -65,7 +64,6 @@ jobs: submodules: recursive fetch-depth: 0 - - run: zig build get-v8 - run: zig build -Doptimize=ReleaseSafe build-v8 - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a @@ -100,7 +98,6 @@ jobs: sudo ln -nsf /usr/lib/llvm-21/lib/clang/21/lib/linux/libclang_rt.builtins-aarch64.a /usr/lib/llvm-21/lib/clang/21/lib/linux/libclang_rt.builtins.a && \ sudo ln -nsf /usr/lib/llvm-21/lib/clang/21/lib/linux/ /usr/lib/llvm-21/lib/clang/21/lib/aarch64-unknown-linux-gnu - - run: zig build get-v8 - run: zig build -Doptimize=ReleaseSafe build-v8 - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a @@ -130,7 +127,6 @@ jobs: submodules: recursive fetch-depth: 0 - - run: zig build get-v8 - run: zig build -Doptimize=ReleaseSafe build-v8 - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a @@ -161,7 +157,6 @@ jobs: submodules: recursive fetch-depth: 0 - - run: OS=macos zig build get-v8 # We force the OS to macos here b/c ios is not supported by get-v8 - run: zig build -Doptimize=ReleaseSafe build-v8 - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.TARGET_ENVIRONMENT }}_${{ env.ARCH }}.a From d03d99e068faf4fc73c106efb3adccf90a0c348d Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Tue, 25 Nov 2025 17:43:43 +0100 Subject: [PATCH 2/2] REMOVE ME --- .github/workflows/build-release.yml | 244 ++++++++++++++-------------- 1 file changed, 123 insertions(+), 121 deletions(-) diff --git a/.github/workflows/build-release.yml b/.github/workflows/build-release.yml index dbd3390..72cf31f 100644 --- a/.github/workflows/build-release.yml +++ b/.github/workflows/build-release.yml @@ -6,6 +6,8 @@ on: - "**" # Allows you to run this workflow manually from the Actions tab workflow_dispatch: + pull_request: + types: [opened, synchronize, reopened, ready_for_review] permissions: contents: write @@ -44,124 +46,124 @@ jobs: allowUpdates: true artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - build-aarch64-macos: - env: - OS: macos - ARCH: aarch64 - - runs-on: macos-latest - steps: - - uses: mlugg/setup-zig@v2 - with: - version: ${{ env.ZIG_VERSION }} - - - uses: actions/setup-python@v5 - with: - python-version: '3.11' - - - uses: actions/checkout@v4 - with: - submodules: recursive - fetch-depth: 0 - - - run: zig build -Doptimize=ReleaseSafe build-v8 - - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - - name: Upload the build - uses: ncipollo/release-action@v1 - with: - allowUpdates: true - artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - build-arm64-linux: - env: - OS: linux - ARCH: aarch64 - - runs-on: ubuntu-22.04-arm - steps: - - uses: mlugg/setup-zig@v2 - with: - version: ${{ env.ZIG_VERSION }} - - - uses: actions/checkout@v4 - with: - submodules: recursive - fetch-depth: 0 - - - run: | - sudo apt-get update - sudo apt-get install -yq libglib2.0-dev lld - wget https://apt.llvm.org/llvm.sh - chmod +x llvm.sh - sudo ./llvm.sh 21 - sudo ln -nsf /usr/lib/llvm-21/lib/clang/21/lib/linux/libclang_rt.builtins-aarch64.a /usr/lib/llvm-21/lib/clang/21/lib/linux/libclang_rt.builtins.a && \ - sudo ln -nsf /usr/lib/llvm-21/lib/clang/21/lib/linux/ /usr/lib/llvm-21/lib/clang/21/lib/aarch64-unknown-linux-gnu - - - run: zig build -Doptimize=ReleaseSafe build-v8 - - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - - name: Upload the build - uses: ncipollo/release-action@v1 - with: - allowUpdates: true - artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - build-x86_64-macos: - env: - OS: macos - ARCH: x86_64 - - runs-on: macos-15-large - steps: - - uses: mlugg/setup-zig@v2 - with: - version: ${{ env.ZIG_VERSION }} - - - uses: actions/setup-python@v5 - with: - python-version: '3.11' - - - uses: actions/checkout@v4 - with: - submodules: recursive - fetch-depth: 0 - - - run: zig build -Doptimize=ReleaseSafe build-v8 - - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - - name: Upload the build - uses: ncipollo/release-action@v1 - with: - allowUpdates: true - artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a - - build-aarch64-ios: - env: - OS: ios - ARCH: aarch64 - TARGET_ENVIRONMENT: simulator - - runs-on: macos-latest - steps: - - uses: mlugg/setup-zig@v2 - with: - version: ${{ env.ZIG_VERSION }} - - - uses: actions/setup-python@v5 - with: - python-version: '3.11' - - - uses: actions/checkout@v4 - with: - submodules: recursive - fetch-depth: 0 - - - run: zig build -Doptimize=ReleaseSafe build-v8 - - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.TARGET_ENVIRONMENT }}_${{ env.ARCH }}.a - - - name: Upload the build - uses: ncipollo/release-action@v1 - with: - allowUpdates: true - artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.TARGET_ENVIRONMENT }}_${{ env.ARCH }}.a + # build-aarch64-macos: + # env: + # OS: macos + # ARCH: aarch64 + + # runs-on: macos-latest + # steps: + # - uses: mlugg/setup-zig@v2 + # with: + # version: ${{ env.ZIG_VERSION }} + + # - uses: actions/setup-python@v5 + # with: + # python-version: '3.11' + + # - uses: actions/checkout@v4 + # with: + # submodules: recursive + # fetch-depth: 0 + + # - run: zig build -Doptimize=ReleaseSafe build-v8 + # - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a + + # - name: Upload the build + # uses: ncipollo/release-action@v1 + # with: + # allowUpdates: true + # artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a + + # build-arm64-linux: + # env: + # OS: linux + # ARCH: aarch64 + + # runs-on: ubuntu-22.04-arm + # steps: + # - uses: mlugg/setup-zig@v2 + # with: + # version: ${{ env.ZIG_VERSION }} + + # - uses: actions/checkout@v4 + # with: + # submodules: recursive + # fetch-depth: 0 + + # - run: | + # sudo apt-get update + # sudo apt-get install -yq libglib2.0-dev lld + # wget https://apt.llvm.org/llvm.sh + # chmod +x llvm.sh + # sudo ./llvm.sh 21 + # sudo ln -nsf /usr/lib/llvm-21/lib/clang/21/lib/linux/libclang_rt.builtins-aarch64.a /usr/lib/llvm-21/lib/clang/21/lib/linux/libclang_rt.builtins.a && \ + # sudo ln -nsf /usr/lib/llvm-21/lib/clang/21/lib/linux/ /usr/lib/llvm-21/lib/clang/21/lib/aarch64-unknown-linux-gnu + + # - run: zig build -Doptimize=ReleaseSafe build-v8 + # - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a + + # - name: Upload the build + # uses: ncipollo/release-action@v1 + # with: + # allowUpdates: true + # artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a + + # build-x86_64-macos: + # env: + # OS: macos + # ARCH: x86_64 + + # runs-on: macos-15-large + # steps: + # - uses: mlugg/setup-zig@v2 + # with: + # version: ${{ env.ZIG_VERSION }} + + # - uses: actions/setup-python@v5 + # with: + # python-version: '3.11' + + # - uses: actions/checkout@v4 + # with: + # submodules: recursive + # fetch-depth: 0 + + # - run: zig build -Doptimize=ReleaseSafe build-v8 + # - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a + + # - name: Upload the build + # uses: ncipollo/release-action@v1 + # with: + # allowUpdates: true + # artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.ARCH }}.a + + # build-aarch64-ios: + # env: + # OS: ios + # ARCH: aarch64 + # TARGET_ENVIRONMENT: simulator + + # runs-on: macos-latest + # steps: + # - uses: mlugg/setup-zig@v2 + # with: + # version: ${{ env.ZIG_VERSION }} + + # - uses: actions/setup-python@v5 + # with: + # python-version: '3.11' + + # - uses: actions/checkout@v4 + # with: + # submodules: recursive + # fetch-depth: 0 + + # - run: zig build -Doptimize=ReleaseSafe build-v8 + # - run: mv v8/out/${{ env.OS }}/release/obj/zig/libc_v8.a libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.TARGET_ENVIRONMENT }}_${{ env.ARCH }}.a + + # - name: Upload the build + # uses: ncipollo/release-action@v1 + # with: + # allowUpdates: true + # artifacts: libc_v8_${{ env.V8_REVISION }}_${{ env.OS }}_${{ env.TARGET_ENVIRONMENT }}_${{ env.ARCH }}.a