Skip to content

Commit 32d9fc0

Browse files
committed
Pass objectGroup as groupName
1 parent 3a7da66 commit 32d9fc0

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

src/cdp/domains/dom.zig

+9-4
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ fn resolveNode(cmd: anytype) !void {
125125
objectGroup: ?[]const u8 = null,
126126
executionContextId: ?u32 = null,
127127
})) orelse return error.InvalidParams;
128-
if (params.nodeId == null or params.backendNodeId != null or params.objectGroup != null or params.executionContextId != null) {
128+
if (params.nodeId == null or params.backendNodeId != null or params.executionContextId != null) {
129129
return error.NotYetImplementedParams;
130130
}
131131

@@ -135,12 +135,17 @@ fn resolveNode(cmd: anytype) !void {
135135
// node._node is a *parder.Node we need this to be able to find its most derived type e.g. Node -> Element -> HTMLElement
136136
// So we use the Node.Union when retrieve the value from the environment
137137
const jsValue = try bc.session.env.findOrAddValue(try dom_node.Node.toInterface(node._node));
138-
const groupName = "AGroupName"; // Temporary default, most likely the same as objectGroup
139-
const remoteObject = try bc.session.inspector.getRemoteObject(&bc.session.env, jsValue, groupName);
138+
const remoteObject = try bc.session.inspector.getRemoteObject(&bc.session.env, jsValue, params.objectGroup orelse "");
140139
defer remoteObject.deinit();
141140

142141
const arena = cmd.arena;
143-
return cmd.sendResult(.{ .object = .{ .type = try remoteObject.getType(arena), .subtype = try remoteObject.getSubtype(arena), .className = try remoteObject.getClassName(arena), .description = try remoteObject.getDescription(arena), .objectId = try remoteObject.getObjectId(arena) } }, .{});
142+
return cmd.sendResult(.{ .object = .{
143+
.type = try remoteObject.getType(arena),
144+
.subtype = try remoteObject.getSubtype(arena),
145+
.className = try remoteObject.getClassName(arena),
146+
.description = try remoteObject.getDescription(arena),
147+
.objectId = try remoteObject.getObjectId(arena),
148+
} }, .{});
144149
}
145150

146151
const testing = @import("../testing.zig");

vendor/zig-js-runtime

0 commit comments

Comments
 (0)