itest: RegisterSpendNtfn detects reorgs

[starius]

Change Description

Added itest "reorg_notifications" which tests that RegisterSpendNtfn behaves as expected during a reorg. A reorg notification is produced after a reorg affects the block which has produced a spending notification for this registration.

Steps to Test

make itest icase='reorg_notifications'
make itest icase='reorg_notifications' backend=btcd
make itest icase='reorg_notifications' backend=neutrino

Pull Request Checklist

Testing

• Your PR passes all CI checks.
• Tests covering the positive and negative (error paths) are included.
• Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

• The change is not insubstantial. Typo fixes are not accepted to fight bot spam.
• The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
• Commits follow the Ideal Git Commit Structure.
• Any new logging statements use an appropriate subsystem and logging level.
• Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
• There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our Contribution Guidelines for further guidance.

[gemini-code-assist]

Summary of Changes

Hello @starius, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial integration test to validate the robustness of the RegisterSpendNtfn RPC in handling blockchain reorgs. The new test case meticulously simulates a reorg event to ensure that clients watching for spending notifications are correctly informed when a confirmed transaction is invalidated and potentially replaced by an alternative transaction on the new chain. This enhances the reliability of chain monitoring within the system.

Highlights

• New Integration Test: I've added a new integration test, testReorgNotifications, to verify the behavior of the RegisterSpendNtfn RPC during blockchain reorgs. This test ensures that the system correctly issues reorg notifications when a previously confirmed spending transaction is unconfirmed due to a chain reorganization.
• Reorg Notification Verification: The test specifically simulates a scenario where an output is spent by one transaction (tx2b), which is then confirmed. After receiving the spending notification, a reorg is triggered that unconfirms tx2b. The test then asserts that a reorg notification is received by the RegisterSpendNtfn client.
• Alternative Spending Confirmation: Following the reorg and the reorg notification, the test confirms an alternative transaction (tx2a) that also spends the same output. It then verifies that a new spending notification is correctly issued for this newly confirmed transaction.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.