Skip to content

Commit 5cec466

Browse files
authored
Merge pull request #9212 from ellemouton/slogFollowUps
multi: update log dep for sub-modules
2 parents c37baa6 + 67419a7 commit 5cec466

File tree

19 files changed

+109
-52
lines changed

19 files changed

+109
-52
lines changed

build/handlers.go

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@ import (
99
// NewDefaultLogHandlers returns the standard console logger and rotating log
1010
// writer handlers that we generally want to use. It also applies the various
1111
// config options to the loggers.
12-
func NewDefaultLogHandlers(cfg *LogConfig, rotator *RotatingLogWriter) (
13-
btclog.Handler, btclog.Handler) {
12+
func NewDefaultLogHandlers(cfg *LogConfig,
13+
rotator *RotatingLogWriter) []btclog.Handler {
14+
15+
var handlers []btclog.Handler
1416

1517
consoleLogHandler := btclog.NewDefaultHandler(
1618
os.Stdout, cfg.Console.HandlerOptions()...,
@@ -19,5 +21,18 @@ func NewDefaultLogHandlers(cfg *LogConfig, rotator *RotatingLogWriter) (
1921
rotator, cfg.File.HandlerOptions()...,
2022
)
2123

22-
return consoleLogHandler, logFileHandler
24+
maybeAddLogger := func(cmdOptionDisable bool, handler btclog.Handler) {
25+
if !cmdOptionDisable {
26+
handlers = append(handlers, handler)
27+
}
28+
}
29+
switch LoggingType {
30+
case LogTypeStdOut:
31+
maybeAddLogger(cfg.Console.Disable, consoleLogHandler)
32+
case LogTypeDefault:
33+
maybeAddLogger(cfg.Console.Disable, consoleLogHandler)
34+
maybeAddLogger(cfg.File.Disable, logFileHandler)
35+
}
36+
37+
return handlers
2338
}

config.go

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import (
2121

2222
"github.com/btcsuite/btcd/btcutil"
2323
"github.com/btcsuite/btcd/chaincfg"
24-
"github.com/btcsuite/btclog/v2"
2524
flags "github.com/jessevdk/go-flags"
2625
"github.com/lightninglabs/neutrino"
2726
"github.com/lightningnetwork/lnd/autopilot"
@@ -1404,32 +1403,14 @@ func ValidateConfig(cfg Config, interceptor signal.Interceptor, fileParser,
14041403
lncfg.NormalizeNetwork(cfg.ActiveNetParams.Name),
14051404
)
14061405

1407-
var (
1408-
logCfg = cfg.LogConfig
1409-
logHandlers []btclog.Handler
1410-
consoleLogHandler, logFileHandler = build.NewDefaultLogHandlers(
1411-
logCfg, cfg.LogRotator,
1412-
)
1413-
)
1414-
maybeAddLogger := func(cmdOptionDisable bool, handler btclog.Handler) {
1415-
if !cmdOptionDisable {
1416-
logHandlers = append(logHandlers, handler)
1417-
}
1418-
}
1419-
switch build.LoggingType {
1420-
case build.LogTypeStdOut:
1421-
maybeAddLogger(logCfg.Console.Disable, consoleLogHandler)
1422-
case build.LogTypeDefault:
1423-
maybeAddLogger(logCfg.Console.Disable, consoleLogHandler)
1424-
maybeAddLogger(logCfg.File.Disable, logFileHandler)
1425-
}
1426-
14271406
if !build.SuportedLogCompressor(cfg.LogCompressor) {
14281407
return nil, mkErr("invalid log compressor: %v",
14291408
cfg.LogCompressor)
14301409
}
14311410

1432-
cfg.SubLogMgr = build.NewSubLoggerManager(logHandlers...)
1411+
cfg.SubLogMgr = build.NewSubLoggerManager(build.NewDefaultLogHandlers(
1412+
cfg.LogConfig, cfg.LogRotator,
1413+
)...)
14331414

14341415
// Initialize logging at the default logging level.
14351416
SetupLoggers(cfg.SubLogMgr, interceptor)

healthcheck/go.mod

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
module github.com/lightningnetwork/lnd/healthcheck
22

3-
go 1.19
4-
53
require (
6-
github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f
4+
github.com/btcsuite/btclog/v2 v2.0.0-20241017175713-3428138b75c7
75
github.com/lightningnetwork/lnd/ticker v1.1.0
86
github.com/lightningnetwork/lnd/tor v1.0.0
97
github.com/stretchr/testify v1.8.2
@@ -13,6 +11,7 @@ require (
1311
require (
1412
github.com/btcsuite/btcd v0.23.2 // indirect
1513
github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1 // indirect
14+
github.com/btcsuite/btclog v0.0.0-20241003133417-09c4e92e319c // indirect
1615
github.com/davecgh/go-spew v1.1.1 // indirect
1716
github.com/kr/pretty v0.3.0 // indirect
1817
github.com/miekg/dns v1.1.43 // indirect
@@ -24,3 +23,5 @@ require (
2423
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect
2524
gopkg.in/yaml.v3 v3.0.1 // indirect
2625
)
26+
27+
go 1.21

healthcheck/go.sum

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,11 @@ github.com/btcsuite/btcd/btcutil v1.0.0/go.mod h1:Uoxwv0pqYWhD//tfTiipkxNfdhG9Ur
99
github.com/btcsuite/btcd/btcutil v1.1.0/go.mod h1:5OapHB7A2hBBWLm48mmw4MOHNJCcUBTwmWH/0Jn8VHE=
1010
github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1 h1:q0rUy8C/TYNBQS1+CGKw68tLOFYSNEs0TFnxxnS9+4U=
1111
github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1/go.mod h1:7SFka0XMvUgj3hfZtydOrQY2mwhPclbT2snogU7SQQc=
12-
github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f h1:bAs4lUbRJpnnkd9VhRV3jjAVU7DJVjMaK+IsvSeZvFo=
1312
github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f/go.mod h1:TdznJufoqS23FtqVCzL0ZqgP5MqXbb4fg/WgDys70nA=
13+
github.com/btcsuite/btclog v0.0.0-20241003133417-09c4e92e319c h1:4HxD1lBUGUddhzgaNgrCPsFWd7cGYNpeFUgd9ZIgyM0=
14+
github.com/btcsuite/btclog v0.0.0-20241003133417-09c4e92e319c/go.mod h1:w7xnGOhwT3lmrS4H3b/D1XAXxvh+tbhUm8xeHN2y3TQ=
15+
github.com/btcsuite/btclog/v2 v2.0.0-20241017175713-3428138b75c7 h1:3Ct3zN3VCEKVm5nceWBBEKczc+jvTfVyOEG71ob2Yuc=
16+
github.com/btcsuite/btclog/v2 v2.0.0-20241017175713-3428138b75c7/go.mod h1:XItGUfVOxotJL8kkuk2Hj3EVow5KCugXl3wWfQ6K0AE=
1417
github.com/btcsuite/btcutil v0.0.0-20190425235716-9e5f4b9a998d/go.mod h1:+5NJ2+qvTyV9exUAL/rxXi3DcLg2Ts+ymUAY5y4NvMg=
1518
github.com/btcsuite/go-socks v0.0.0-20170105172521-4720035b7bfd/go.mod h1:HHNXQzUsZCxOoE+CPiyCTO6x34Zs86zZUiwtpXoGdtg=
1619
github.com/btcsuite/goleveldb v0.0.0-20160330041536-7834afc9e8cd/go.mod h1:F+uVaaLLH7j4eDXPRvw78tMflu7Ie2bzYOH4Y8rRKBY=

healthcheck/log.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
package healthcheck
22

3-
import (
4-
"github.com/btcsuite/btclog"
5-
)
3+
import "github.com/btcsuite/btclog/v2"
64

75
// Subsystem defines the logging code for this subsystem.
86
const Subsystem = "HLCK"

kvdb/go.mod

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
module github.com/lightningnetwork/lnd/kvdb
22

33
require (
4-
github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f
4+
github.com/btcsuite/btclog/v2 v2.0.0-20241017175713-3428138b75c7
55
github.com/btcsuite/btcwallet/walletdb v1.4.4
66
github.com/davecgh/go-spew v1.1.1
77
github.com/fergusstrange/embedded-postgres v1.25.0
@@ -26,6 +26,7 @@ require (
2626
github.com/beorn7/perks v1.0.1 // indirect
2727
github.com/btcsuite/btcd v0.23.2 // indirect
2828
github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1 // indirect
29+
github.com/btcsuite/btclog v0.0.0-20241003133417-09c4e92e319c // indirect
2930
github.com/cenkalti/backoff/v4 v4.1.3 // indirect
3031
github.com/cespare/xxhash/v2 v2.2.0 // indirect
3132
github.com/containerd/continuity v0.3.0 // indirect

kvdb/go.sum

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,11 @@ github.com/btcsuite/btcd/btcutil v1.0.0/go.mod h1:Uoxwv0pqYWhD//tfTiipkxNfdhG9Ur
3737
github.com/btcsuite/btcd/btcutil v1.1.0/go.mod h1:5OapHB7A2hBBWLm48mmw4MOHNJCcUBTwmWH/0Jn8VHE=
3838
github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1 h1:q0rUy8C/TYNBQS1+CGKw68tLOFYSNEs0TFnxxnS9+4U=
3939
github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1/go.mod h1:7SFka0XMvUgj3hfZtydOrQY2mwhPclbT2snogU7SQQc=
40-
github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f h1:bAs4lUbRJpnnkd9VhRV3jjAVU7DJVjMaK+IsvSeZvFo=
4140
github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f/go.mod h1:TdznJufoqS23FtqVCzL0ZqgP5MqXbb4fg/WgDys70nA=
41+
github.com/btcsuite/btclog v0.0.0-20241003133417-09c4e92e319c h1:4HxD1lBUGUddhzgaNgrCPsFWd7cGYNpeFUgd9ZIgyM0=
42+
github.com/btcsuite/btclog v0.0.0-20241003133417-09c4e92e319c/go.mod h1:w7xnGOhwT3lmrS4H3b/D1XAXxvh+tbhUm8xeHN2y3TQ=
43+
github.com/btcsuite/btclog/v2 v2.0.0-20241017175713-3428138b75c7 h1:3Ct3zN3VCEKVm5nceWBBEKczc+jvTfVyOEG71ob2Yuc=
44+
github.com/btcsuite/btclog/v2 v2.0.0-20241017175713-3428138b75c7/go.mod h1:XItGUfVOxotJL8kkuk2Hj3EVow5KCugXl3wWfQ6K0AE=
4245
github.com/btcsuite/btcutil v0.0.0-20190425235716-9e5f4b9a998d/go.mod h1:+5NJ2+qvTyV9exUAL/rxXi3DcLg2Ts+ymUAY5y4NvMg=
4346
github.com/btcsuite/btcwallet/walletdb v1.4.4 h1:BDel6iT/ltYSIYKs0YbjwnEDi7xR3yzABIsQxN2F1L8=
4447
github.com/btcsuite/btcwallet/walletdb v1.4.4/go.mod h1:jk/hvpLFINF0C1kfTn0bfx2GbnFT+Nvnj6eblZALfjs=

kvdb/log.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package kvdb
22

33
import (
4-
"github.com/btcsuite/btclog"
4+
"github.com/btcsuite/btclog/v2"
55
"github.com/lightningnetwork/lnd/kvdb/sqlbase"
66
)
77

kvdb/postgres/db.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ func newPostgresBackend(ctx context.Context, config *Config, prefix string) (
2828
Schema: "public",
2929
TableNamePrefix: prefix,
3030
SQLiteCmdReplacements: sqliteCmdReplacements,
31+
WithTxLevelLock: true,
3132
}
3233

3334
return sqlbase.NewSqlBackend(ctx, cfg)

kvdb/sqlbase/db.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,10 @@ type Config struct {
5555
// commands. Note that the sqlite keywords to be replaced are
5656
// case-sensitive.
5757
SQLiteCmdReplacements SQLiteCmdReplacements
58+
59+
// WithTxLevelLock when set will ensure that there is a transaction
60+
// level lock.
61+
WithTxLevelLock bool
5862
}
5963

6064
// db holds a reference to the sql db connection.
@@ -75,6 +79,10 @@ type db struct {
7579
// db is the underlying database connection instance.
7680
db *sql.DB
7781

82+
// lock is the global write lock that ensures single writer. This is
83+
// only used if cfg.WithTxLevelLock is set.
84+
lock sync.RWMutex
85+
7886
// table is the name of the table that contains the data for all
7987
// top-level buckets that have keys that cannot be mapped to a distinct
8088
// sql table.

0 commit comments

Comments
 (0)