f fixes from jeff and 3257

Author: TheBlueMatt

CHANGELOG.md

@@ -29,15 +29,15 @@
    `OnChainSweep` and only being used when the on-chain sweep is urgent (#3268).
  * All `ChannelMonitor`s are no longer persisted after each block connection,
    instead spreading them out over a handful of blocks to reduce load spikes.
-   Note that this will increase the incidence of `ChannelMonitor`s which have
+   Note that this will increase the incidence of `ChannelMonitor`s that have
    different best blocks on startup, requiring some additional chain replay
    (but only on some `ChannelMonitor`s) on startup for `Listen` users (#2966).
  * A new format for Rapid Gossip Sync data is now supported which contains
    additional node metadata and is more extensible (#3098).
  * `ChannelManager::send_payment_with_route` is now deprecated in favor of the
    much easier to use `Channelmanager::send_payment`. Those who wish to manually
    select the route such payments go over should do so by matching the
-   `payment_id` in `Router::find_route_with_id` (#3224).
+   `payment_id` passed to `send_payment` in `Router::find_route_with_id` (#3224)
  * `lightning-transaction-sync` now takes most `Confirm`s as a generic `Deref`.
    You may need an explicit `as &(dyn Confirm)` to update existing code (#3101).
  * HTLCs will now be forwarded over any channel with a peer, rather than only
@@ -62,7 +62,7 @@
  * BOLT 12 invoice requests now go out over, and accept responses over, multiple
    paths (#3087).
  * `OnionMessenger` now supports intercepting and re-forwarding onion messages
-   for peers which are offline at the time of receipt when constructed with
+   for peers that are offline at the time of receipt when constructed with
    `new_with_offline_peer_interception` (#2973).
  * Onion message handling trait methods now generally take a `Responder` which
    can be used to create a `ResponseInstruction` to better control how responses
@@ -73,14 +73,17 @@
  * Blinded paths used for BOLT 12 `Offer`/`Refund`s are now compact when they
    expire relatively soon, making them somewhat smaller (#3011, #3080).
  * `ChannelManager::force_close_*` now take a err msg to send to peers (#2889).
+ * `ChannelDetails::is_public` has been renamed to `is_announced` and
+   `ChannelHandshakeConfig::announced_channel` to `announce_for_forwarding` to
+   address various misconceptions about the purpose of announcement (#3257).
  * `BlindedPath`s are now split into `BlindedMessagePath`s and
    `BlindedPaymentPath`s and `advance_path_by_one` added to each (#3182).
  * `BlindedPaymentPath` now includes the `BlindedPayInfo` (#3245).
  * BOLT 12 `Offer`/`Refund` builders no longer require a description, instead
    allowing it to be set on the builder itself (#3018).
  * The `{Inbound,Outbound}HTLCState{,Details}` and `ChannelDetails` structs have
    moved to the `ln::channel_state` module (#3089).
- * `Event::OpenChannelRequest` now contains `params` and `is_public` (#3019).
+ * `Event::OpenChannelRequest` now contains `params` and `is_announced` (#3019).
  * Peers are no longer disconnected when we force-close a channel (#3088).
  * BOLT12 `Offer` and `Refund` now implement `Readable` (#2965).
  * `RecipientOnionFields` is now included in `Event::PaymentClaimed` (#3084).
@@ -96,10 +99,10 @@
    applied to the network graph via `Event::PaymentPathFailed`, preventing a
    node along the path from identifying the sender of a payment (#3083).
  * In order to prevent senders from identifying the recipient of a BOLT 12 offer
-   which included a blinded path, cryptographic information from blinded paths
+   that included a blinded path, cryptographic information from blinded paths
    are now included in the invoice request verification (#3085, #3139, #3242).
  * Routes are now length-limited based on the actual onion contents rather than
-   a fixed value. This ensures no routes are generated which are unpayable when
+   a fixed value. This ensures no routes are generated that are unpayable when
    sending HTLCs with custom TLVs, blinded paths, or metadata (#3026, #3156).
  * Unannounced LDK nodes (or ones without a network graph) will now include
    unannounced peers as introduction points in blinded paths. This addresses
@@ -130,7 +133,7 @@
    be persisted in the `ChannelMonitor` for one or more MPP parts, resulting in
    only some of the payment's value being claimed (#3120).
  * A rare race was fixed which could lead to `ChannelMonitorUpdate`s appearing
-   after a full `ChannelMonitor` persistence which already contained the same
+   after a full `ChannelMonitor` persistence that already contained the same
    update. This could have caused a panic on startup for users of the
    `MonitorUpdatingPersister` in rare cases after a crash (#3196).
  * Background Processor is now woken from `ChainMonitor` when new blocks appear,
@@ -168,7 +171,7 @@
  * LDK now supports BOLT 12 Offers without descriptions when no amount is
    present (#3018).
  * A bug was fixed which might have led to LDK spuriously rejecting
-   `channel_update`s which use as-yet-undefined flag bits (#3144).
+   `channel_update`s that use as-yet-undefined flag bits (#3144).
 
 XXX change stats