fixup: correct to_self balance in new for inbound

Author: tankyleo

lightning/src/ln/channel.rs

@@ -2766,14 +2766,18 @@ impl<SP: Deref> ChannelContext<SP> where SP::Target: SignerProvider {
 			return Err(ChannelError::close(format!("Dust limit ({}) too high for the channel reserve we require the remote to keep ({})", open_channel_fields.dust_limit_satoshis, holder_selected_channel_reserve_satoshis)));
 		}
 
+		// v1 channel opens set `our_funding_satoshis` to 0, and v2 channel opens set `msg_push_msat` to 0.
+		debug_assert!(our_funding_satoshis == 0 || msg_push_msat == 0);
+		let value_to_self_msat = our_funding_satoshis * 1000 + msg_push_msat;
+
 		// check if the funder's amount for the initial commitment tx is sufficient
 		// for full fee payment plus a few HTLCs to ensure the channel will be useful.
 		let funders_amount_msat = open_channel_fields.funding_satoshis * 1000 - msg_push_msat;
 		let CommitmentStats {
 			total_fee_sat,
 			local_balance_before_fee_msat: _,
 			remote_balance_before_fee_msat,
-		} = SpecTxBuilder {}.build_commitment_stats(false, open_channel_fields.commitment_feerate_sat_per_1000_weight, MIN_AFFORDABLE_HTLC_COUNT, msg_push_msat, funders_amount_msat, &channel_type);
+		} = SpecTxBuilder {}.build_commitment_stats(false, open_channel_fields.commitment_feerate_sat_per_1000_weight, MIN_AFFORDABLE_HTLC_COUNT, value_to_self_msat, funders_amount_msat, &channel_type);
 		if remote_balance_before_fee_msat / 1000 < total_fee_sat {
 			return Err(ChannelError::close(format!("Funding amount ({} sats) can't even pay fee for initial commitment transaction fee of {} sats.", remote_balance_before_fee_msat / 1000, total_fee_sat)));
 		}
@@ -2832,8 +2836,6 @@ impl<SP: Deref> ChannelContext<SP> where SP::Target: SignerProvider {
 			Some(cmp::max(config.channel_handshake_config.minimum_depth, 1))
 		};
 
-		let value_to_self_msat = our_funding_satoshis * 1000 + msg_push_msat;
-
 		// TODO(dual_funding): Checks for `funding_feerate_sat_per_1000_weight`?
 
 		let pubkeys = holder_signer.pubkeys(None, &secp_ctx);