Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't allow NaNs in posted json #34

Open
mathisonian opened this issue Oct 11, 2015 · 0 comments
Open

don't allow NaNs in posted json #34

mathisonian opened this issue Oct 11, 2015 · 0 comments

Comments

@mathisonian
Copy link
Member

With the current setup its possible for the python client to send invalid json to the server (causing a hard to debug 500 there), because by default json.dump allows NaNs to be included in the generated json. I propose setting allow_nan=False in all json.dump calls to avoid this and generate a clear error on the client.

cc @freeman-lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant