Merge pull request #222 from lightbend/encodeCookie

2m · web-flow · commit 428a7da929e1 · 2018-08-01T17:40:09.000+03:00
Encode cookie header
diff --git a/themes/generic/src/main/assets/js/groups.js b/themes/generic/src/main/assets/js/groups.js
@@ -25,7 +25,7 @@ $(function() {
     var d = new Date();
     d.setTime(d.getTime() + (exdays*24*60*60*1000));
     var expires = "expires=" + d.toGMTString();
-    document.cookie = cname + "=" + cvalue + ";" + expires + ";path=/";
+    document.cookie = cname + "=" + encodeURIComponent(cvalue) + ";" + expires + ";path=/";
   }
 
   // http://www.w3schools.com/js/js_cookies.asp

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ $(function() {`
`25`	`25`	`var d = new Date();`
`26`	`26`	`d.setTime(d.getTime() + (exdays2460601000));`
`27`	`27`	`var expires = "expires=" + d.toGMTString();`
`28`		`- document.cookie = cname + "=" + cvalue + ";" + expires + ";path=/";`
	`28`	`+ document.cookie = cname + "=" + encodeURIComponent(cvalue) + ";" + expires + ";path=/";`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`// http://www.w3schools.com/js/js_cookies.asp`