Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot based testing #15

Closed
carueda opened this issue Jan 27, 2023 · 2 comments
Closed

snapshot based testing #15

carueda opened this issue Jan 27, 2023 · 2 comments

Comments

@carueda
Copy link
Collaborator

carueda commented Jan 27, 2023

In the spirit of project/development setup adjustments (complementary to #6) and for improved testing capabilities, it would be good to consider snapshot based testing, which I have used very successfully/productively in other projects, in concrete, using syrupy, which is a pytest plugin.

So, the idea here would be:

  • if desired/needed, replace current unittest based tests with pytest (but probably not really necessary)
  • add some basic snapshot tests to demonstrate functionality/benefits
  • then add more tests and/or possibly morph some of the current ones into using snapshots

cc @danellecline

@carueda
Copy link
Collaborator Author

carueda commented Jan 31, 2023

PR #18 (draft, initially)

@carueda
Copy link
Collaborator Author

carueda commented Mar 15, 2023

closing per merged #18 - thanks!

@carueda carueda closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant