Correct some coverity issues from "avoid IFD overwriting".

Author: SuLaus

contrib/addtiffo/tif_overview.c

@@ -149,7 +149,8 @@ uint32_t TIFF_WriteOverview(TIFF *hTIFF, uint32_t nXSize, uint32_t nYSize,
     if (TIFFWriteCheck(hTIFF, bTiled, "TIFFBuildOverviews") == 0)
         return 0;
 
-    TIFFWriteDirectory(hTIFF);
+    if (!TIFFWriteDirectory(hTIFF))
+        return 0;
     iNumDir = TIFFNumberOfDirectories(hTIFF);
     if (iNumDir > TIFF_DIR_MAX)
     {

contrib/iptcutil/iptcutil.c

@@ -446,7 +446,6 @@ int main(int argc, char *argv[])
         int inputlen = BUFFER_SZ;
 
         line = (char *)malloc(inputlen);
-        token = (char *)NULL;
         while ((line = super_fgets(line, &inputlen, ifile)) != NULL)
         {
             state = 0;
@@ -518,9 +517,7 @@ int main(int argc, char *argv[])
                 state++;
             }
             free(token);
-            token = (char *)NULL;
             free(newstr);
-            newstr = (char *)NULL;
         }
         free(line);
 

libtiff/tif_dirread.c

@@ -4310,7 +4310,7 @@ int TIFFReadDirectory(TIFF *tif)
         TIFFErrorExtR(
             tif, module,
             "Failed to allocate memory for counting IFD data size at reading");
-        return 0;
+        goto bad;
     }
     /*
      * Electronic Arts writes gray-scale TIFF files
@@ -5279,6 +5279,8 @@ int TIFFReadCustomDirectory(TIFF *tif, toff_t diroff,
         TIFFErrorExtR(
             tif, module,
             "Failed to allocate memory for counting IFD data size at reading");
+        if (dir)
+            _TIFFfreeExt(tif, dir);
         return 0;
     }
 

libtiff/tif_dirwrite.c

@@ -2014,7 +2014,7 @@ static int TIFFWriteDirectoryTagIfdIfd8Array(TIFF *tif, uint32_t *ndir,
 static void EvaluateIFDdatasizeWrite(TIFF *tif, uint32_t count,
                                      uint32_t typesize, uint32_t *ndir)
 {
-    uint64_t datalength = count * typesize;
+    uint64_t datalength = (uint64_t)count * typesize;
     if (datalength > ((tif->tif_flags & TIFF_BIGTIFF) ? 0x8U : 0x4U))
     {
         /* LibTIFF increments write adress to an even offset, thus datalenght

test/rewrite_tag.c

@@ -255,7 +255,7 @@ int rewrite_test(const char *filename, uint32_t width, int length, int bigtiff,
 
     upd_bytecount = (uint64_t *)_TIFFmalloc(sizeof(uint64_t) * length);
     for (i = 0; i < length; i++)
-        upd_bytecount[i] = 100 + i * width;
+        upd_bytecount[i] = 100 + (uint64_t)i * width;
 
     if (!_TIFFRewriteField(tif, TIFFTAG_STRIPBYTECOUNTS, TIFF_LONG8, length,
                            upd_bytecount))
@@ -308,7 +308,7 @@ int rewrite_test(const char *filename, uint32_t width, int length, int bigtiff,
 
     for (i = 0; i < length; i++)
     {
-        uint64_t expect = 100 + i * width;
+        uint64_t expect = 100 + (uint64_t)i * width;
 
         if (rowbytes[i] != expect)
         {

test/test_IFD_enlargement.c

@@ -917,7 +917,7 @@ int test_EXIF_enlargement(const char *filename, bool is_big_tiff)
             goto failure;
         }
         /* Set EXIFIFD tag with dummy value to reserve space in IFD. */
-        if (!TIFFSetField(tif, TIFFTAG_EXIFIFD, 0))
+        if (!TIFFSetField(tif, TIFFTAG_EXIFIFD, (uint64_t)0))
         {
             fprintf(stderr, "Can't set TIFFTAG_EXIFIFD tag. Testline %d\n",
                     __LINE__);