-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Metrics for GossipSub #534
Comments
You can easily implement this with a tracer. So an option to enable metrics, that hooks a tracer into you preferred metrics system is something the library could provide == see how it is handled in lotus. Changing protocol code to directly hook metrics is not acceptable however. |
In Prysm, we have already implemented something pretty similar using a raw tracer: |
If you’d consider upstreaming a patch, I’d be happy to review |
Thank you for the offer, I am bit occupied over the next few weeks, but once I get some bandwidth I can open up a PR for this to be upstreamed if no-one has done it yet. |
Please use a Just to be clear, I also think it would be a welcome addition to have in tree support for this. |
Metrics such as:
We should also include some grafana dashboards.
This should help node operators identify when their node is running into issues, or when GossipSub is limping along but still working.
The text was updated successfully, but these errors were encountered: