Fix closeOnError: call cb() before close() (#293)

* closeOnError: call cb() before close()

Signed-off-by: Igor Egorov <[email protected]>

* Countable yamux and yamux read buffer

* Count yamux metrics forcefully

* Revert "Count yamux metrics forcefully"

This reverts commit 88cdeed.

* Revert "Countable yamux and yamux read buffer"

This reverts commit e171915.

---------

Signed-off-by: Igor Egorov <[email protected]>

Author: igor-egorov

src/security/tls/tls_connection.cpp

@@ -132,8 +132,9 @@ namespace libp2p::connection {
                                                               auto &&result) {
       if (ec) {
         SL_DEBUG(log(), "connection async op error {}", ec);
+        cb(ec);
         std::ignore = conn->close();
-        return cb(ec);
+        return;
       }
       cb(std::forward<decltype(result)>(result));
     };

src/transport/tcp/tcp_connection.cpp

@@ -95,8 +95,9 @@ namespace libp2p::transport {
                                                               auto result) {
         if (auto self = wptr.lock()) {
           if (ec) {
+            cb(ec);
             self->close(ec);
-            return cb(ec);
+            return;
           }
           TRACE("{} {}", self->str(), result);
           cb(result);