Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openssl to 1.0.2o #652

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Update openssl to 1.0.2o #652

merged 1 commit into from
Apr 10, 2018

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Apr 9, 2018

@pks-t mentioned CVEs against the version we're using, so let's update.

Extracted from #645, because that fix will need more work.

@tiennou
Copy link
Contributor Author

tiennou commented Apr 9, 2018

I'd like to propose switching libssh2's backend to mbedTLS, because I don't think #648 can be realistically made to work without any external dependencies.

@pietbrauer @phatblat Opinions ?

@phatblat
Copy link
Member

phatblat commented Apr 10, 2018

I haven't heard of mbedTLS before, but I'm game as long as there's a decent community to support it and we can build it on Apple platforms. Would this replace the CommonCrypto used by macOS in libssh2?

As for the license, they say it is dual licensed as both Apache 2 or GPL 2. I would think we'd want to use Apache 2 so that it would be compatible with this repo's MIT license. I just want to make sure people can use this repo to build apps that they make money from, without having to give away the source code. It looks like they have the Apache 2 license in their github repo, so probably a non-issue.

@phatblat
Copy link
Member

What version of OpenSSL does this PR bring us up to? Are we on 1.0.2p-dev now as the readme in the OpenSSL_1_0_2-stable branch says?

@tiennou
Copy link
Contributor Author

tiennou commented Apr 10, 2018

It seems the world moved since I updated my submodule, so I've pointed it at 1.0.2o which was released 27/03 instead of tracking stable.

Would this replace the CommonCrypto used by macOS in libssh2?

We don't have that, and AFAICT we're not likely to have it (see #648). Arguably, I'm not even sure of my reasons for asking a change, since whatever we do we'd have to package ourselves, it just felt like mbedTLS might be easier but it's a hunch.

@phatblat
Copy link
Member

Ah, that’s right. Well, it would be nice to get rid of openssl

@phatblat
Copy link
Member

Can you rename the PR to reflect the version?

@tiennou tiennou changed the title Update openssl to 1.0.2-stable Update openssl to 1.0.2o Apr 10, 2018
@tiennou
Copy link
Contributor Author

tiennou commented Apr 10, 2018

:shipit:

@phatblat phatblat merged commit 2ab216a into libgit2:master Apr 10, 2018
@tiennou tiennou deleted the update-openssl branch April 23, 2018 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants