WIP

Author: bording

LibGit2Sharp/Configuration.cs

@@ -52,9 +52,9 @@ internal Configuration(
         private void Init(Repository repository)
         {
             configHandle = Proxy.git_config_new();
-            RepositoryHandle repoHandle = (repository != null) ? repository.Handle : null;
+            RepositoryHandle repoHandle = repository?.Handle ?? new RepositoryHandle();
 
-            if (repoHandle != null)
+            if (!repoHandle.IsInvalid)
             {
                 //TODO: push back this logic into libgit2.
                 // As stated by @carlosmn "having a helper function to load the defaults and then allowing you

LibGit2Sharp/Core/Proxy.cs

@@ -438,9 +438,7 @@ public static unsafe SignatureInfo git_commit_extract_signature(RepositoryHandle
 
         public static unsafe void git_config_add_file_ondisk(ConfigurationHandle config, FilePath path, ConfigurationLevel level, RepositoryHandle repo)
         {
-            // RepositoryHandle does implicit cast voodoo that is not null-safe, thus this explicit check
-            RepositoryHandle repoHandle = (repo != null) ? (RepositoryHandle)repo : null;
-            int res = NativeMethods.git_config_add_file_ondisk(config, path, (uint)level, repoHandle, true);
+            int res = NativeMethods.git_config_add_file_ondisk(config, path, (uint)level, repo, true);
             Ensure.ZeroResult(res);
         }