Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exception raised when parsing #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tiennou
Copy link
Contributor

@tiennou tiennou commented Jun 3, 2021

It seems Clang can arbitrarily raise errors (transient NULL-byte reads from files that exist). Handle those errors by retrying the parsing step 3 times, just in case it goes away.

@carlosmn
Copy link
Member

carlosmn commented Jun 3, 2021

I guess that didn't solve the issue on Ruby 2.6. It's curious that it's happening on that version and seemingly not the others.

@tiennou
Copy link
Contributor Author

tiennou commented Jun 3, 2021

What's really weird is that I'm running ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin18], and it doesn't happen at all here. I've been running while [ $? ]; do rake test TESTOPTS="-v --name=test_can_group_functions"; done for a while, and it still hasn't stopped 🙄.

It seems Clang can arbitrarily raise errors (transient NULL-byte reads
from files that exist). Handle those errors by retrying the parsing step
3 times, just in case it goes away.
@tiennou tiennou force-pushed the fix/retry-parsing branch from d464de3 to bb20bda Compare June 18, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants