Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: consequent changes for 1-based line indexing #53

Merged
merged 3 commits into from
Dec 26, 2024
Merged

chore: consequent changes for 1-based line indexing #53

merged 3 commits into from
Dec 26, 2024
+17 −0

Conversation

Pranavchiku
Copy link
Member

Consequent PR of lfortran/lfortran#5818

@Pranavchiku Pranavchiku mentioned this pull request Dec 25, 2024
Merged
@certik @Pranavchiku
Update server/src/lfortran-accessors.ts
fb2fb3b 
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
Copy link
Member Author

The checks fail because they are written considering 0 based line indexing. Will push a fix.

@certik
Copy link
Contributor

certik commented Dec 25, 2024

This will be needed too: #54

certik
certik approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge this to unblock us.

@dylon once you get to reviewing this, if there is an issue, just send a new PR with a fix.

@certik certik requested a review from dylon December 26, 2024 21:12
@certik certik merged commit 90d1851 into lfortran:main Dec 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik

@dylon dylon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pranavchiku @certik