Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation still mentions images URLs as an option #294

Closed
nicorikken opened this issue Aug 31, 2021 · 4 comments
Closed

Documentation still mentions images URLs as an option #294

nicorikken opened this issue Aug 31, 2021 · 4 comments

Comments

@nicorikken
Copy link
Contributor

According to the readme one should be able to submit a image URL. Turns out that triggers a build error, as in #293 So the README could use an update. Perhaps there is more current documentation in the CNCF-landscape repo that can be adopted?
@jmertic
Copy link
Contributor

jmertic commented Aug 31, 2021

@nicorikken - Review the updated page and let me know if that addresses your issue.

@nicorikken
Copy link
Contributor Author

nicorikken commented Aug 31, 2021 •
edited
Loading

Nope, I see that it is still there:

If you think your project should be included, please open a pull request to add it to landscape.yml. For the logo, you can either upload an SVG to the hosted_logos directory or put a URL as the value, and it will be fetched.

I shall open a PR.

jmertic added a commit that referenced this issue Aug 31, 2021
@jmertic
Fixed logo instructions
33c054b 
Fixes #294 for real this time :-)

Signed-off-by: John Mertic <[email protected]>
@jmertic
Copy link
Contributor

jmertic commented Aug 31, 2021

Somehow missed that - fixed now.

@nicorikken nicorikken mentioned this issue Aug 31, 2021
Closed
@nicorikken
Copy link
Contributor Author

Nice, I was working on a PR, you beat me to it. Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update documentation on logo location
2 participants
@jmertic @nicorikken