Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Different classes matched #1

Open
lem0n4id opened this issue Feb 26, 2022 · 0 comments
Open

Bug: Different classes matched #1

lem0n4id opened this issue Feb 26, 2022 · 0 comments
Assignees
@lem0n4id
Labels
bug Something isn't working

Comments

@lem0n4id
Copy link
Owner

Describe the bug

My friend and I have different classes yet it matched.

Specifically, it matched L49-BCSE103E-ELA-AB1-706-ALL and L46-BCSE103E-ELA-AB1-706-ALL

To Reproduce

Steps to reproduce the behavior:

  1. Paste L49-BCSE103E-ELA-AB1-706-ALL in text box 1
  2. Paste L46-BCSE103E-ELA-AB1-706-ALL in text box 2

Expected behavior

It shouldn't match because the slots(L49, L46) are different

Todo

Change the algorithm which matches the courses

Currently, the app matches courses by courseid-venue.

Since classes with the same venue and slot won't have different professors, we need to find the set of courses such that

  • courseid and venue matches
  • atleast one slot matches
@lem0n4id lem0n4id added the bug Something isn't working label Feb 26, 2022
@lem0n4id lem0n4id self-assigned this Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lem0n4id lem0n4id

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lem0n4id