Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obfuscate secret in Joi validation errors #458

Open
nathanforce opened this issue Jan 21, 2025 · 0 comments
Open

Obfuscate secret in Joi validation errors #458

nathanforce opened this issue Jan 21, 2025 · 0 comments

Comments

@nathanforce
Copy link

Context

  • 18
  • ^5.1.0
  • Node

What problem are you trying to solve?

When providing an invalid config to one of the constructors, in our case AuthorizationCode, we receive a helpful Joi ValidationError. The problem, though, is that this error includes the provided config, which includes the secret, which gets logged to stdout and picked up by logging services.

Do you have a new or modified API suggestion to solve the problem?

I'd suggested replacing the logged secret with [REDACTED].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant