-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReferenceError: Buffer is not defined in tools.js #25
Comments
I have the same problem "typescript": "~3.7.5" |
Same problem, I ended up using your workaround and now everything works. It's because this library calls one of the functions from the original NodeJs library (which expects the Buffer type) |
Same problem for me, but I think the solution cannot replace all |
instructure-gerrit
pushed a commit
to instructure/canvas-lms
that referenced
this issue
Jul 6, 2022
See legokichi/ts-ebml#25 This is not a great fix, or a good place to put the fix; we're just putting in a workaround so we can get Canvas deployed. Once ARC-8398 is understood and resolved, we should revert this PS. Change-Id: I4d71ecc32b76105dcdcfb12c2de4b062d1ca48a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/295603 Tested-by: Service Cloud Jenkins <[email protected]> Product-Review: Weston Dransfield <[email protected]> Reviewed-by: Weston Dransfield <[email protected]> QA-Review: Weston Dransfield <[email protected]>
instructure-gerrit
pushed a commit
to instructure/canvas-lms
that referenced
this issue
Jul 6, 2022
See legokichi/ts-ebml#25 This is not a great fix, or a good place to put the fix; we're just putting in a workaround so we can get Canvas deployed. Once ARC-8398 is understood and resolved, we should revert this PS. Change-Id: I4d71ecc32b76105dcdcfb12c2de4b062d1ca48a4 Reviewed-on: https://gerrit.instructure.com/c/canvas-lms/+/295603 Tested-by: Service Cloud Jenkins <[email protected]> Product-Review: Weston Dransfield <[email protected]> Reviewed-by: Weston Dransfield <[email protected]> QA-Review: Weston Dransfield <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have this issue on web, my build system is based on TypeScript 2.9.2, relevant lines from tsconfig:
For now I can work around it by setting Buffer on window.
The text was updated successfully, but these errors were encountered: