Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All PhET channels are being marked as being in English, and other language/text issues #7

Open
jamalex opened this issue Feb 23, 2023 · 1 comment

Comments

@jamalex
Copy link
Member

jamalex commented Feb 23, 2023

The code is pretty messy, and would benefit from a refactor, but I'm guessing this line may be the culprit (or there are several other candidates, as English is hardcoded at the top, too): https://github.com/learningequality/sushi-chef-phet/blob/master/chef.py#L187

Some other related improvements:

  • I'm guessing we can get language-specific descriptions from the PhET API or website, rather than hardcoding them here. Or at the very least, we should add more languages into the hardcoding -- most languages we support don't have them hardcoded in here at the moment.
  • Channel names should not just be "channel PhET Interactive Simulations-". Why does it say "channel" at the beginning? Why do we use the English name ("Interactive Simulation")? And I think we're trying to move away from using langcodes in user-facing text.
@jamalex
Copy link
Member Author

jamalex commented Feb 23, 2023

Ah, it looks as if most of those were made public but then subsequently deleted
image

So hopefully we're in the process of addressing those issues before reviving the channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant