Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - check if the downloaded resources are not corrupted #478

Open
radinamatic opened this issue Mar 4, 2024 · 1 comment
Open
Assignees

Comments

@radinamatic
Copy link
Member

Observed behavior

Experience from building the Funda Wande channel: slow network or the source page may have been causing glitches during the resource download, which in turn resulted in the corrupted PDF files that were unable to open in Kolibri, and several back and forth between the developer cheffing and the QA.

Maybe we could add something to the chef workflow to prevent this type of issues, a step to check that downloaded PDF files are not corrupted and potentially re-trying the download before proceeding to upload to Studio?

@rtibbles
Copy link
Member

Interestingly, we don't do any of this validation except implicitly when we happen to look at the file for other purposes (like getting the duration from a video file). I am doing some other work that is adding some of this validation in other places - with that foundation, we should be able to add validation for different specific file types fairly easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants