Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor downloader.py to make more functions unit testable #303

Open
kollivier opened this issue Feb 1, 2021 · 0 comments
Open

Refactor downloader.py to make more functions unit testable #303

kollivier opened this issue Feb 1, 2021 · 0 comments

Comments

@kollivier
Copy link
Contributor

Description

Currently, there are a lot of programming practices, like inner functions, in downloader.py that prevent us from unit testing features such as URL detection and re-writing. This leads to whack-a-mole bug fixing since we don't have the resources to test all existing sources with any changes we make.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kollivier