Setup Wizard - 'Responsibilities of administrator' is shown twice when importing from a device with multiple facilities

[pcenov]

Observed behavior

The 'Responsibilities of administrator' page is shown twice when importing from a device with one or multiple facilities:

responsibilities.mp4

The issue is extant in both 0.17.3 and 0.18.

Expected behavior

The 'Responsibilities of administrator' page should be displayed only once.

Steps to reproduce the issue

1. Install the build asset from Conditionalize hideContinue on whether we are displaying an error or not #12893 on one device.
2. Install it on another device.
3. On the first device setup a device with one or multiple facilities
4. On the second device go through the 'Import all data from an existing learning facility' flow.

Logs

logs.zip

Usage Details

Kolibri 0.17.3 and 0.18
Ubuntu 22 - Chrome

[pcenov]

@radinamatic

[MisRob]

Here's a guide on Running another Kolibri instance alongside the development server

[Jeevansm25]

Can I take this issue?

[AlexVelezLl]

Hi @Jeevansm25! For sure! I will assign this issue to you. Please be aware that this issue is in our setup_wizard plugin. To reproduce this issue you need to have a fresh start of Kolibri so you will need to create new folders and override your KOLIBRI_HOME, or remove your default KOLIBRI_HOME folder each time you finished the setup and want to reproduce it again. To have another Kolibri instance running for the import step you can check MisRob's comment. Let us know if you have any questions.

[Jeevansm25]

I have identified the issue and corrected the code. Now, I would like to test the changes. Previously, before correcting the code, I downloaded the .pex file from the workflow. Could you guide me on how to test the updated code?

…

On Tue, Dec 3, 2024 at 4:24 PM Alex Velez ***@***.***> wrote: Assigned #12894 <#12894> to @Jeevansm25 <https://github.com/Jeevansm25>. — Reply to this email directly, view it on GitHub <#12894 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A7BGIILW6YCTFGZXD5MLBAD2DWEV5AVCNFSM6AAAAABSVKBLOKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVGUYDONRRG4ZDMMI> . You are receiving this because you were assigned.Message ID: ***@***.***>

[MisRob]

Hi @Jeevansm25, if you follow the guide I posted on running the two instances, one of them is a development server. Open Kolibri from its URL and it should have your latest local updates.

You can consider the other .pex instance just for having the other facility available - generally it shouldn't be problem for it to run on the older version. Let us know if this work, and if not, please post more details on what exactly you're doing.

[Jeevansm25]

Hi @Jeevansm25, if you follow the guide I posted on running the two instances, one of them is a development server. Open Kolibri from its URL and it should have your latest local updates.

You can consider the other .pex instance just for having the other facility available - generally it shouldn't be problem for it to run on the older version. Let us know if this work, and if not, please post more details on what exactly you're doing.

After making the changes in the code, do we need to build the project first and then run the Kolibri instances, or can we directly run the instances to see the updates reflected?

Looking forward to your clarification.

[MisRob]

@Jeevansm25 if you follow the guide step by step and get to "Run your development server", then upon running yarn run devserver or yarn run devserver-hot, you only need to update code and you should see the updates reflected without the need to rebuild the .pex or rerun the development server.

[MisRob]

@Jeevansm25 if you haven't yet done so, set up your development server https://kolibri-dev.readthedocs.io/en/develop/getting_started.html#getting-started

[Jeevansm25]

@Jeevansm25 if you haven't yet done so, set up your development server https://kolibri-dev.readthedocs.io/en/develop/getting_started.html#getting-started

Of course, I followed all these steps, but I didn't see the changes I made on the development server reflected in the instance running through the .pex file. Could you please clarify this step for me?

[MisRob]

I didn't see the changes I made on the development server reflected in the instance running through the .pex file.

@Jeevansm25 Yes, you won't see the changes on the .pex instance. You'd need to build .pex locally for that. I've never done that but could ask others if needed. However, for the majority of tasks it's not needed, perhaps only in some nuanced cases that have to do something with synchronization. I am not sure if this issue is such a case. Would you tell a bit more about why you think you need this?

[Jeevansm25]

I didn't see the changes I made on the development server reflected in the instance running through the .pex file.

@Jeevansm25 Yes, you won't see the changes on the .pex instance. You'd need to build .pex locally for that. I've never done that but could ask others if needed. However, for the majority of tasks it's not needed, perhaps only in some nuanced cases that have to do something with synchronization. I am not sure if this issue is such a case. Would you tell a bit more about why you think you need this?

Thank you for clarifying about the .pex instance! I was testing a synchronization issue where "Responsibilities of administrator" appears twice when importing from a device with multiple facilities. I wanted to confirm if this issue was fixed by my development changes. Since the .pex instance doesn’t reflect the changes, I now understand that I might need to build a new .pex file. Could you guide me if building it locally is a standard process here, or should I explore other approaches?

[MisRob]

I wanted to confirm if this issue was fixed by my development changes.

@Jeevansm25 I'm trying to understand why you can't confirm it on the instance with the development server - what's the nature of your fix? Hopefully then I can then recommend some alternatives if needed. Regarding rebuilding pex, I need to check on this, will get back to you later.

[MisRob]

@Jeevansm25 regarding .pex builds, if it's really needed then my colleague recommends

pip install -r requirements/build.txt
make dist
make pex

[MisRob]

Hi @Jeevansm25, I wanted to mention that Learning Equality will be closed from December 23 to January 5.

[karankoder]

Hi @MisRob, I noticed that this issue is still open, and it seems @Jeevansm25 is not actively working on it. Could you please assign this issue to me? I'd like to take it up.

[Jeevansm25]

Actually I am working on it. If I can't will notice you.

…

On Mon, 6 Jan, 2025, 19:43 Karan Kumar Das, ***@***.***> wrote: Hi @MisRob <https://github.com/MisRob>, I noticed that this issue is still open, and it seems @Jeevansm25 <https://github.com/Jeevansm25> is not actively working on it. Could you please assign this issue to me? I'd like to take it up. — Reply to this email directly, view it on GitHub <#12894 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A7BGIIIH4YPHY4DXEA3AUDT2JKFQXAVCNFSM6AAAAABSVKBLOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZTGE4TMMBUGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[karankoder]

Hi @Jeevansm25,

Thanks for letting me know! I'll look for another issue to contribute to.

[Jeevansm25]

Could we test the updated code using a Jest file? If so, where should we place the Jest file in the project structure?
[The test ensures the mounted method is only called once.]

[AlexVelezLl]

Hey @Jeevansm25! Yes, we do use jest for testing. You can follow our testing guidelines.