Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should fail if warnings are generated during the build #256

Open
kim-em opened this issue Jan 4, 2025 · 1 comment
Open

CI should fail if warnings are generated during the build #256

kim-em opened this issue Jan 4, 2025 · 1 comment

Comments

@kim-em
Copy link
Contributor

kim-em commented Jan 4, 2025

See https://github.com/leanprover/doc-gen4/actions/runs/12607913996/job/35139815612#step:3:79, which resulted in us merging #255 (and tagging v4.16.0-rc1) incorrectly.
@hargoniX hargoniX mentioned this issue Jan 4, 2025
Merged
@hargoniX
Copy link
Collaborator

hargoniX commented Jan 5, 2025

As pointed out here: https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/Lean.20action.20not.20failing.20on.20.60lake.20build.20--wfail.60.20on.20docgen/near/491977688 #257 cannot fully address this issue as --wfail does not fail on configuration warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kim-em @hargoniX