Skip to content

Commit 767f036

Browse files
committed
[NKIFE-423] fix reduce_cmd default value
1 parent 3a0f4eb commit 767f036

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

KLR/Trace/ISA.lean

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ nki builtin.isa.activation
193193
(scale : Sum Immediate Access := .inl $ .float 1.0) -- This also can accept a tensor
194194
(reduce_op : Option AluOp := none)
195195
(reduce_res : Option Access := none)
196-
(reduce_cmd : AccumCmd := .Idle)
196+
(reduce_cmd : AccumCmd := .ZeroAccumulate)
197197
(mask : Option Immediate := none)
198198
(name : Option String := none) := do
199199
if mask.isSome then
@@ -220,7 +220,6 @@ nki builtin.isa.activation_reduce
220220
-- kwargs
221221
(reduce_op : Option AluOp := none)
222222
(reduce_res : Option Access := none)
223-
(reduce_cmd : AccumCmd := .Idle)
224223
(bias : Option Access := none )
225224
(scale : Sum Immediate Access := .inl $ .float 1.0)
226225
(mask : Option Immediate := none)
@@ -239,7 +238,7 @@ nki builtin.isa.activation_reduce
239238
bias := bias.map .abstract,
240239
reduceOp := reduce_op,
241240
reduceRes := reduce_res.map .abstract,
242-
accumulatorCmd := reduce_cmd,
241+
accumulatorCmd := .ZeroAccumulate,
243242
dtype := dst.tensor.dtype,
244243
}) name
245244
return .none

0 commit comments

Comments
 (0)