Merge pull request #220 from leeyeh/master

fix(query): throw error instead of return rejected Promise.

Author: wangxiao

lib/query.js

@@ -187,7 +187,7 @@ module.exports = function(AV) {
       if(!objectId) {
         var errorObject = new AV.Error(AV.Error.OBJECT_NOT_FOUND,
                                           "Object not found.");
-        return AV.Promise.error(errorObject);
+        throw errorObject;
       }
 
       var self = this;

lib/user.js

@@ -251,7 +251,7 @@ module.exports = function(AV) {
         if (options && options.error) {
           options.error(this, error);
         }
-        return AV.Promise.error(error);
+        throw error;
       }
 
       var password = (attrs && attrs.password) || this.get("password");
@@ -262,7 +262,7 @@ module.exports = function(AV) {
         if (options && options.error) {
           options.error(this, error);
         }
-        return AV.Promise.error(error);
+        throw error;
       }
 
       return this.save(attrs, filterOutCallbacks(options)).then(function(model) {
@@ -304,7 +304,7 @@ module.exports = function(AV) {
         if (options && options.error) {
           options.error(this, error);
         }
-        return AV.Promise.error(error);
+        throw error;
       }
 
       var smsCode = (attrs && attrs.smsCode) || this.get("smsCode");
@@ -316,7 +316,7 @@ module.exports = function(AV) {
         if (options && options.error) {
           options.error(this, error);
         }
-        return AV.Promise.error(error);
+        throw error;
       }
 
       var newOptions = filterOutCallbacks(options);
@@ -737,9 +737,9 @@ module.exports = function(AV) {
      * logged in user using <code>current</code>.
      *
      * <p>Calls options.success or options.error on completion.</p>
-     * 
+     *
      * @param {Object} data The response json data returned from third party token.
-     * @param {string} platform Available platform for sign up. 
+     * @param {string} platform Available platform for sign up.
      * @param {Object} [callback] An object that has an optional success function, that takes no arguments and will be called on a successful puSH. and an error function that takes a AV.Error and will be called if the push failed.
      * @return {AV.Promise} A promise that is fulfilled with the user when
      *     the login completes.

test/query.js

@@ -23,6 +23,24 @@ describe("Queries", function () {
 
     });
 
+    it("should throw when get null", function () {
+
+      query = new AV.Query(GameScore);
+      expect(function() {
+        query.get(null, {
+          success: function () {},
+          error: function () {}
+        });
+      }).to.throwError();
+      expect(function() {
+        query.get(undefined, {
+          success: function () {},
+          error: function () {}
+        });
+      }).to.throwError();
+
+    });
+
   });
 
   describe("#cloudQuery", function () {

test/user.js

@@ -28,7 +28,18 @@ describe("User", function() {
 
     });
 
-
+    it("should throw when required field missing", function() {
+      var user = new AV.User();
+      user.set("username", username);
+      expect(function() {
+        user.signUp(null);
+      }).to.throwError(/password/);
+      var user = new AV.User();
+      user.set("password", password);
+      expect(function() {
+        user.signUp(null);
+      }).to.throwError(/name/);
+    });
   });
 
   describe("User.logIn and User.become", function() {
@@ -219,14 +230,14 @@ describe("User", function() {
 
   describe("User logInAnonymously", function() {
     it("should create anonymous user, and login with AV.User.signUpOrlogInWithAuthData()", function(done) {
-      var getFixedId = function () {  
+      var getFixedId = function () {
         var rawId = 13334230101333423010;
-        var result = rawId.toString(16);  
-        return result;  
+        var result = rawId.toString(16);
+        return result;
+      }
+      var data = {
+        id: getFixedId()
       }
-      var data = {  
-        id: getFixedId()  
-      }  
 
       AV.User.signUpOrlogInWithAuthData(data, "anonymous", {
         success: function(user) {