diff --git a/hapi/__init__.py b/hapi/__init__.py index 6b8aaf4..059a173 100644 --- a/hapi/__init__.py +++ b/hapi/__init__.py @@ -80,7 +80,26 @@ def download(data_dir: str = None) -> str: import tarfile with tarfile.open(os.path.join(data_dir, "hapi.tar.gz")) as tar: - tar.extractall(data_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, data_dir) return data_dir