fix!: Rename nest parameters under model

Author: keelerm84

ldai/client.py

@@ -21,7 +21,7 @@ class ModelConfig:
     Configuration related to the model.
     """
 
-    def __init__(self, id: str, parameters: dict = {}):
+    def __init__(self, id: str, parameters: Optional[Dict[str, Any]] = None):
         """
         :param id: The ID of the model.
         :param parameters: Additional model-specific parameters.
@@ -46,6 +46,9 @@ def get_parameter(self, key: str) -> Any:
         if key == 'id':
             return self.id
 
+        if self._parameters is None:
+            return None
+
         return self._parameters.get(key)
 
 
@@ -123,10 +126,11 @@ def config(
             provider_config = ProviderConfig(provider.get('id', ''))
 
         model = None
-        if 'model' in variation:
+        if 'model' in variation and isinstance(variation['model'], dict):
+            parameters = variation['model'].get('parameters', None)
             model = ModelConfig(
                 id=variation['model']['id'],
-                parameters=variation['model'],
+                parameters=parameters
             )
 
         enabled = variation.get('_ldMeta', {}).get('enabled', False)

ldai/testing/test_model_config.py

@@ -13,7 +13,7 @@ def td() -> TestData:
         td.flag('model-config')
         .variations(
             {
-                'model': {'id': 'fakeModel', 'temperature': 0.5, 'maxTokens': 4096},
+                'model': {'id': 'fakeModel', 'parameters': {'temperature': 0.5, 'maxTokens': 4096}},
                 'provider': {'id': 'fakeProvider'},
                 'messages': [{'role': 'system', 'content': 'Hello, {{name}}!'}],
                 '_ldMeta': {'enabled': True, 'versionKey': 'abcd'},
@@ -27,7 +27,7 @@ def td() -> TestData:
         td.flag('multiple-messages')
         .variations(
             {
-                'model': {'id': 'fakeModel', 'temperature': 0.7, 'maxTokens': 8192},
+                'model': {'id': 'fakeModel', 'parameters': {'temperature': 0.7, 'maxTokens': 8192}},
                 'messages': [
                     {'role': 'system', 'content': 'Hello, {{name}}!'},
                     {'role': 'user', 'content': 'The day is, {{day}}!'},
@@ -43,7 +43,7 @@ def td() -> TestData:
         td.flag('ctx-interpolation')
         .variations(
             {
-                'model': {'id': 'fakeModel', 'extra-attribute': 'I can be anything I set my mind/type to'},
+                'model': {'id': 'fakeModel', 'parameters': {'extra-attribute': 'I can be anything I set my mind/type to'}},
                 'messages': [{'role': 'system', 'content': 'Hello, {{ldctx.name}}!'}],
                 '_ldMeta': {'enabled': True, 'versionKey': 'abcd'},
             }
@@ -55,7 +55,7 @@ def td() -> TestData:
         td.flag('off-config')
         .variations(
             {
-                'model': {'id': 'fakeModel', 'temperature': 0.1},
+                'model': {'id': 'fakeModel', 'parameters': {'temperature': 0.1}},
                 'messages': [{'role': 'system', 'content': 'Hello, {{name}}!'}],
                 '_ldMeta': {'enabled': False, 'versionKey': 'abcd'},
             }