chore: addressing PR feedback

Author: joker23

packages/shared/sdk-server/src/data_sources/fileDataInitilizerFDv2.ts

@@ -25,7 +25,6 @@ export default class FileDataInitializerFDv2 implements subsystemCommon.DataSour
   private _yamlParser?: (data: string) => any;
   private _fileLoader?: FileLoader;
 
-  // TODO: do a options check here
   constructor(config: Configuration, platform: Platform) {
     const options = config.dataSystem?.dataSource?.initializerOptions as FileDataInitializerOptions;
     this._validateInputs(options, platform);
@@ -78,17 +77,15 @@ export default class FileDataInitializerFDv2 implements subsystemCommon.DataSour
       this._paths,
       false, // autoupdate is always false for initializer
       (results: { path: string; data: string }[]) => {
-        // Whenever changes are detected we re-process all of the data.
-        // The FileLoader will have handled debouncing for us.
         try {
           const parsedData = this._processFileData(results);
 
-          statusCallback(subsystemCommon.DataSourceState.Valid);
-
           payloadProcessor.addPayloadListener((payload) => {
             dataCallback(payload.basis, { initMetadata, payload });
           });
 
+          statusCallback(subsystemCommon.DataSourceState.Valid);
+
           payloadProcessor.processEvents(parsedData.events);
 
           statusCallback(subsystemCommon.DataSourceState.Closed);
@@ -102,7 +99,16 @@ export default class FileDataInitializerFDv2 implements subsystemCommon.DataSour
       },
     );
 
-    this._fileLoader.loadAndWatch();
+    this._fileLoader.loadAndWatch().catch((err) => {
+      this._logger?.error('Error loading files', err);
+      statusCallback(
+        subsystemCommon.DataSourceState.Closed,
+        new LDPollingError(
+          DataSourceErrorKind.NetworkError,
+          `Failed to load files: ${err instanceof Error ? err.message : String(err)}`,
+        ),
+      );
+    });
   }
 
   private _processFileData(results: { path: string; data: string }[]) {

packages/shared/sdk-server/src/options/Configuration.ts

@@ -253,7 +253,12 @@ function validateDataSystemOptions(options: Options): {
     }
     // Preserve initializer options if it was provided, since it's not validated by validateTypesAndNames.
     // Currently, setting this option is most commonly used as an override of default initializer options.
-    if (options.dataSource && 'initializerOptions' in options.dataSource) {
+    // Check that the value is not undefined to avoid overwriting defaults when explicitly set to undefined.
+    if (
+      options.dataSource &&
+      'initializerOptions' in options.dataSource &&
+      options.dataSource.initializerOptions !== undefined
+    ) {
       validatedDataSourceOptions.initializerOptions = options.dataSource.initializerOptions;
     }