Skip to content

Commit 9ba587a

Browse files
committed
ci: simplify for attestation-only releases (no draft needed)
Since actions/attest@v4 stores attestations via GitHub's attestation API (not as release assets), repos that only use attestation don't need draft releases. Release-please can publish the release directly. Changes: - Remove draft:true from release-please-config.json - Remove create-tag job/steps (force-tag-creation handles this) - Remove publish-release job (release is published directly) - Remove publish_release input from manual workflows
1 parent 55a6d53 commit 9ba587a

3 files changed

Lines changed: 0 additions & 55 deletions

File tree

.github/workflows/manual-publish.yml

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@ on:
1010
description: 'Tag of an existing draft release to upload artifacts to.'
1111
type: string
1212
required: false
13-
publish_release:
14-
description: 'Publish (un-draft) the release after all artifacts are uploaded?'
15-
type: boolean
16-
required: false
17-
default: true
1813

1914
jobs:
2015
build-publish:
@@ -62,19 +57,3 @@ jobs:
6257
uses: actions/attest@v4
6358
with:
6459
subject-checksums: checksums.txt
65-
66-
publish-release:
67-
needs: ['build-publish']
68-
if: ${{ !inputs.dry_run && inputs.publish_release }}
69-
runs-on: ubuntu-latest
70-
permissions:
71-
contents: write
72-
steps:
73-
- name: Publish release
74-
env:
75-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
76-
TAG_NAME: ${{ inputs.tag }}
77-
run: >
78-
gh release edit "$TAG_NAME"
79-
--repo ${{ github.repository }}
80-
--draft=false

.github/workflows/release-please.yml

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -34,23 +34,6 @@ jobs:
3434
with:
3535
branch: ${{ fromJSON(steps.release.outputs.pr).headBranchName }}
3636

37-
- name: Create release tag
38-
if: ${{ steps.release.outputs.releases_created == 'true' }}
39-
env:
40-
TAG_NAME: ${{ steps.release.outputs.tag_name }}
41-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
42-
run: |
43-
if gh api "repos/${{ github.repository }}/git/ref/tags/${TAG_NAME}" >/dev/null 2>&1; then
44-
echo "Tag ${TAG_NAME} already exists, skipping creation."
45-
else
46-
echo "Creating tag ${TAG_NAME}."
47-
git tag "${TAG_NAME}"
48-
git push origin "${TAG_NAME}"
49-
fi
50-
51-
#
52-
# These remaining steps are ONLY run if a release was actually created
53-
#
5437
- uses: launchdarkly/gh-actions/actions/release-secrets@release-secrets-v1.2.0
5538
name: "Get Hackage token"
5639
if: ${{ steps.release.outputs.releases_created == 'true' }}
@@ -99,19 +82,3 @@ jobs:
9982
uses: actions/attest@v4
10083
with:
10184
subject-checksums: checksums.txt
102-
103-
publish-release:
104-
needs: ['release-package']
105-
if: ${{ needs.release-package.outputs.release-created == 'true' }}
106-
runs-on: ubuntu-latest
107-
permissions:
108-
contents: write
109-
steps:
110-
- name: Publish release
111-
env:
112-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
113-
TAG_NAME: ${{ needs.release-package.outputs.upload-tag-name }}
114-
run: >
115-
gh release edit "$TAG_NAME"
116-
--repo ${{ github.repository }}
117-
--draft=false

release-please-config.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
{
22
"packages": {
33
".": {
4-
"draft": true,
54
"force-tag-creation": true,
65
"release-type": "simple",
76
"bump-minor-pre-major": true,

0 commit comments

Comments
 (0)